All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mel Gorman <mgorman@suse.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: mtk.manpages@gmail.com, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] posix_fadvise.2: Document the behaviour of partial page discard requests
Date: Tue, 30 Dec 2014 21:48:52 +0100	[thread overview]
Message-ID: <54A30FB4.8020606@gmail.com> (raw)
In-Reply-To: <1417567367-9298-3-git-send-email-mgorman@suse.de>

On 12/03/2014 01:42 AM, Mel Gorman wrote:
> It is not obvious from the interface that partial page discard requests
> are ignored. It should be spelled out.

Thanks, Mel. Applied.

Cheers,

Michael


> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
>  man2/posix_fadvise.2 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man2/posix_fadvise.2 b/man2/posix_fadvise.2
> index 25d0c50..07313a9 100644
> --- a/man2/posix_fadvise.2
> +++ b/man2/posix_fadvise.2
> @@ -144,6 +144,11 @@ A program may periodically request the kernel to free cached data
>  that has already been used, so that more useful cached pages are not
>  discarded instead.
>  
> +Requests to discard partial pages are ignored. It is preferable to preserve
> +needed data than discard unneeded data. If the application requires that
> +data be considered for discarding then \fIoffset\fP and \fIlen\fP must be
> +page-aligned.
> +
>  Pages that have not yet been written out will be unaffected, so if the
>  application wishes to guarantee that pages will be released, it should
>  call
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mel Gorman <mgorman@suse.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: mtk.manpages@gmail.com, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] posix_fadvise.2: Document the behaviour of partial page discard requests
Date: Tue, 30 Dec 2014 21:48:52 +0100	[thread overview]
Message-ID: <54A30FB4.8020606@gmail.com> (raw)
In-Reply-To: <1417567367-9298-3-git-send-email-mgorman@suse.de>

On 12/03/2014 01:42 AM, Mel Gorman wrote:
> It is not obvious from the interface that partial page discard requests
> are ignored. It should be spelled out.

Thanks, Mel. Applied.

Cheers,

Michael


> Signed-off-by: Mel Gorman <mgorman@suse.de>
> ---
>  man2/posix_fadvise.2 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man2/posix_fadvise.2 b/man2/posix_fadvise.2
> index 25d0c50..07313a9 100644
> --- a/man2/posix_fadvise.2
> +++ b/man2/posix_fadvise.2
> @@ -144,6 +144,11 @@ A program may periodically request the kernel to free cached data
>  that has already been used, so that more useful cached pages are not
>  discarded instead.
>  
> +Requests to discard partial pages are ignored. It is preferable to preserve
> +needed data than discard unneeded data. If the application requires that
> +data be considered for discarding then \fIoffset\fP and \fIlen\fP must be
> +page-aligned.
> +
>  Pages that have not yet been written out will be unaffected, so if the
>  application wishes to guarantee that pages will be released, it should
>  call
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  reply	other threads:[~2014-12-30 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  0:42 [PATCH 0/2] Improve documentation of FADV_DONTNEED behaviour Mel Gorman
2014-12-03  0:42 ` Mel Gorman
2014-12-03  0:42 ` [PATCH 1/2] mm: fadvise: Document the fadvise(FADV_DONTNEED) behaviour for partial pages Mel Gorman
2014-12-03  0:42   ` Mel Gorman
2014-12-03  0:42 ` [PATCH 2/2] posix_fadvise.2: Document the behaviour of partial page discard requests Mel Gorman
2014-12-03  0:42   ` Mel Gorman
2014-12-30 20:48   ` Michael Kerrisk (man-pages) [this message]
2014-12-30 20:48     ` Michael Kerrisk (man-pages)
2014-12-30 20:51 ` [PATCH 0/2] Improve documentation of FADV_DONTNEED behaviour Michael Kerrisk (man-pages)
2014-12-30 20:51   ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A30FB4.8020606@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.