From: Vlad Zolotarov <vladz@cloudius-systems.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, gleb@cloudius-systems.com,
avi@cloudius-systems.com
Subject: Re: [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code
Date: Wed, 31 Dec 2014 19:01:03 +0200 [thread overview]
Message-ID: <54A42BCF.8000904@cloudius-systems.com> (raw)
In-Reply-To: <1420043307.31582.53.camel@jtkirshe-mobl>
On 12/31/14 18:28, Jeff Kirsher wrote:
> On Wed, 2014-12-31 at 11:51 +0200, Vlad Zolotarov wrote:
>> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>
>> ---
>> New in v1 (compared to RFC):
>> - Use "if-else" statement instead of a "switch-case" for a single
>> option case
>> (in ixgbevf_get_rss_key()).
>>
>> ---
>> drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 ++
>> drivers/net/ethernet/intel/ixgbevf/vf.c | 44
>> ++++++++++++++++++++++++++++++++
>> drivers/net/ethernet/intel/ixgbevf/vf.h | 1 +
>> 3 files changed, 47 insertions(+)
> Just caught this now, sorry but your patch description is sparse (i.e.
> non-existent). I know that the title of the patch pretty much tells
> what you are doing, but it would be nice to have a bit more detail as to
> why (like your first patch).
>
> Same goes for patch 5 of the series as well.
No problema. ;)
Will send the v2.
next prev parent reply other threads:[~2014-12-31 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 9:51 [PATCH net-next v1 0/5]: ixgbevf: Allow querying VFs RSS indirection table and key Vlad Zolotarov
2014-12-31 9:51 ` [PATCH net-next v1 1/5] ixgbe: Add a RETA query command to VF-PF channel API Vlad Zolotarov
2014-12-31 9:51 ` [PATCH net-next v1 2/5] ixgbevf: Add a RETA query code Vlad Zolotarov
2014-12-31 18:00 ` Alexander Duyck
2014-12-31 18:33 ` Vlad Zolotarov
2015-01-01 18:09 ` Alexander Duyck
2015-01-02 17:49 ` Vlad Zolotarov
2014-12-31 9:51 ` [PATCH net-next v1 3/5] ixgbe: Add GET_RSS_KEY command to VF-PF channel commands set Vlad Zolotarov
2014-12-31 9:51 ` [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code Vlad Zolotarov
2014-12-31 16:28 ` Jeff Kirsher
2014-12-31 17:01 ` Vlad Zolotarov [this message]
2014-12-31 18:03 ` Vlad Zolotarov
2014-12-31 18:32 ` Jeff Kirsher
2014-12-31 18:36 ` Vlad Zolotarov
2014-12-31 9:51 ` [PATCH net-next v1 5/5] ixgbevf: Add the appropriate ethtool ops to query RSS indirection table and key Vlad Zolotarov
2014-12-31 16:01 ` [PATCH net-next v1 0/5]: ixgbevf: Allow querying VFs " Jeff Kirsher
2014-12-31 16:20 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A42BCF.8000904@cloudius-systems.com \
--to=vladz@cloudius-systems.com \
--cc=avi@cloudius-systems.com \
--cc=gleb@cloudius-systems.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.