All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Leon Alrae" <leon.alrae@imgtec.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x
Date: Thu, 01 Jan 2015 17:15:15 +0100	[thread overview]
Message-ID: <54A57293.10605@suse.de> (raw)
In-Reply-To: <1419813550-26182-4-git-send-email-laurent@vivier.eu>

Hi Laurent,

Am 29.12.2014 um 01:39 schrieb Laurent Vivier:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  hw/mips/mips_jazz.c      |   2 +-
>  hw/net/dp8393x.c         | 182 +++++++++++++++++++++++++++++++----------------
>  include/hw/net/dp8393x.h |   1 -
>  3 files changed, 121 insertions(+), 64 deletions(-)

Thanks for doing this cleanup! "QOM'ify" would be more correct
(subject). Patch looks good except for one nit: Can you distinguish
between instance_init and realize function rather than using the old
SysBusDeviceClass::init?

Also, can dp83932_init() be inlined in the call site, or is it used in
multiple places?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

  reply	other threads:[~2015-01-01 16:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29  0:39 [Qemu-devel] [PATCH 0/3] dp8393x update Laurent Vivier
2014-12-29  0:39 ` [Qemu-devel] [PATCH 1/3] dp8393x: add registers offset Laurent Vivier
2014-12-29  0:39 ` [Qemu-devel] [PATCH 2/3] dp8393x: add PROM to store MAC address Laurent Vivier
2014-12-29  0:39 ` [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x Laurent Vivier
2015-01-01 16:15   ` Andreas Färber [this message]
2015-01-01 17:32     ` Laurent Vivier
2015-01-01 21:01 ` [Qemu-devel] [PATCH 0/3] dp8393x update Hervé Poussineau
2015-01-02  1:34   ` Laurent Vivier
2015-01-02  9:25     ` Laurent Vivier
2015-01-02 10:19       ` Peter Maydell
2015-01-02 11:33         ` Laurent Vivier
2015-01-02 12:31           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A57293.10605@suse.de \
    --to=afaerber@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=hpoussin@reactos.org \
    --cc=laurent@vivier.eu \
    --cc=leon.alrae@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.