From: Larry Finger <Larry.Finger@lwfinger.net>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Brett Rudley <brudley@broadcom.com>,
Arend van Spriel <arend@broadcom.com>
Cc: Hante Meuleman <meuleman@broadcom.com>,
Kalle Valo <kvalo@adurom.com>, Fabian Frederick <fabf@skynet.be>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions
Date: Sun, 04 Jan 2015 00:21:40 -0600 [thread overview]
Message-ID: <54A8DBF4.4050202@lwfinger.net> (raw)
In-Reply-To: <1420332469-5907-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 01/03/2015 06:47 PM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> dma_txflush() dma_txsuspended()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/dma.c | 19 -------------------
> drivers/net/wireless/brcm80211/brcmsmac/dma.h | 2 --
> 2 files changed, 21 deletions(-)
Just because file dma.c is involved, it does not need to be, nor should it be in
the subject line. You could specify the driver names in the file tree after
wireless. In this instance, one possible subject would be "brcm80211: brcmsmac:
Remove some unused functions". On the other hand, if you look at "git log" to
see past patches, the driver maintainers even leave off the brcm80211 part, thus
to match them, the subject should be "brcmsmac: Remove some unused functions".
As was suggested earlier, you need to look at the precedents. Keeping a uniform
method of patch naming helps when looking for patches in the git log.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Rickard Strandqvist
<rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>,
Brett Rudley <brudley-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Arend van Spriel <arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Hante Meuleman <meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Kalle Valo <kvalo-BkwN83ws05HQT0dZR+AlfA@public.gmane.org>,
Fabian Frederick <fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions
Date: Sun, 04 Jan 2015 00:21:40 -0600 [thread overview]
Message-ID: <54A8DBF4.4050202@lwfinger.net> (raw)
In-Reply-To: <1420332469-5907-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
On 01/03/2015 06:47 PM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> dma_txflush() dma_txsuspended()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/dma.c | 19 -------------------
> drivers/net/wireless/brcm80211/brcmsmac/dma.h | 2 --
> 2 files changed, 21 deletions(-)
Just because file dma.c is involved, it does not need to be, nor should it be in
the subject line. You could specify the driver names in the file tree after
wireless. In this instance, one possible subject would be "brcm80211: brcmsmac:
Remove some unused functions". On the other hand, if you look at "git log" to
see past patches, the driver maintainers even leave off the brcm80211 part, thus
to match them, the subject should be "brcmsmac: Remove some unused functions".
As was suggested earlier, you need to look at the precedents. Keeping a uniform
method of patch naming helps when looking for patches in the git log.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-04 6:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 0:47 [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions Rickard Strandqvist
2015-01-04 6:21 ` Larry Finger [this message]
2015-01-04 6:21 ` Larry Finger
2015-01-04 12:43 ` Rickard Strandqvist
2015-01-04 12:43 ` Rickard Strandqvist
2015-01-05 10:49 ` Kalle Valo
2015-01-05 11:06 ` Arend van Spriel
2015-01-06 23:33 ` Rickard Strandqvist
2015-01-07 6:29 ` Julia Lawall
2015-01-07 8:58 ` Arend van Spriel
2015-01-09 17:58 ` Rickard Strandqvist
2015-01-09 17:58 ` Rickard Strandqvist
2015-01-07 8:57 ` Arend van Spriel
2015-01-05 10:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A8DBF4.4050202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=fabf@skynet.be \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.