* [PATCH] arch: m68k: 68360: config: Remove unused function
@ 2015-01-02 21:05 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2015-01-02 21:05 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Ungerer
Cc: Rickard Strandqvist, linux-m68k, linux-kernel
Remove the function BSP_set_clock_mmss() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/m68k/68360/config.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/arch/m68k/68360/config.c b/arch/m68k/68360/config.c
index 17ec416..fd1f948 100644
--- a/arch/m68k/68360/config.c
+++ b/arch/m68k/68360/config.c
@@ -106,19 +106,6 @@ void hw_timer_init(irq_handler_t handler)
pquicc->timer_tgcr = tgcr_save;
}
-int BSP_set_clock_mmss(unsigned long nowtime)
-{
-#if 0
- short real_seconds = nowtime % 60, real_minutes = (nowtime / 60) % 60;
-
- tod->second1 = real_seconds / 10;
- tod->second2 = real_seconds % 10;
- tod->minute1 = real_minutes / 10;
- tod->minute2 = real_minutes % 10;
-#endif
- return 0;
-}
-
void BSP_reset (void)
{
local_irq_disable();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arch: m68k: 68360: config: Remove unused function
@ 2015-01-02 21:05 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2015-01-02 21:05 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Ungerer
Cc: Rickard Strandqvist, linux-m68k, linux-kernel
Remove the function BSP_set_clock_mmss() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/m68k/68360/config.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/arch/m68k/68360/config.c b/arch/m68k/68360/config.c
index 17ec416..fd1f948 100644
--- a/arch/m68k/68360/config.c
+++ b/arch/m68k/68360/config.c
@@ -106,19 +106,6 @@ void hw_timer_init(irq_handler_t handler)
pquicc->timer_tgcr = tgcr_save;
}
-int BSP_set_clock_mmss(unsigned long nowtime)
-{
-#if 0
- short real_seconds = nowtime % 60, real_minutes = (nowtime / 60) % 60;
-
- tod->second1 = real_seconds / 10;
- tod->second2 = real_seconds % 10;
- tod->minute1 = real_minutes / 10;
- tod->minute2 = real_minutes % 10;
-#endif
- return 0;
-}
-
void BSP_reset (void)
{
local_irq_disable();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arch: m68k: 68360: config: Remove unused function
2015-01-02 21:05 ` Rickard Strandqvist
@ 2015-01-05 0:29 ` Greg Ungerer
-1 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2015-01-05 0:29 UTC (permalink / raw)
To: Rickard Strandqvist, Geert Uytterhoeven; +Cc: linux-m68k, linux-kernel
Hi Rickard,
On 03/01/15 07:05, Rickard Strandqvist wrote:
> Remove the function BSP_set_clock_mmss() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, I'll add it to the m68knommu git tree.
Regards
Greg
> ---
> arch/m68k/68360/config.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/m68k/68360/config.c b/arch/m68k/68360/config.c
> index 17ec416..fd1f948 100644
> --- a/arch/m68k/68360/config.c
> +++ b/arch/m68k/68360/config.c
> @@ -106,19 +106,6 @@ void hw_timer_init(irq_handler_t handler)
> pquicc->timer_tgcr = tgcr_save;
> }
>
> -int BSP_set_clock_mmss(unsigned long nowtime)
> -{
> -#if 0
> - short real_seconds = nowtime % 60, real_minutes = (nowtime / 60) % 60;
> -
> - tod->second1 = real_seconds / 10;
> - tod->second2 = real_seconds % 10;
> - tod->minute1 = real_minutes / 10;
> - tod->minute2 = real_minutes % 10;
> -#endif
> - return 0;
> -}
> -
> void BSP_reset (void)
> {
> local_irq_disable();
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arch: m68k: 68360: config: Remove unused function
@ 2015-01-05 0:29 ` Greg Ungerer
0 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2015-01-05 0:29 UTC (permalink / raw)
To: Rickard Strandqvist, Geert Uytterhoeven; +Cc: linux-m68k, linux-kernel
Hi Rickard,
On 03/01/15 07:05, Rickard Strandqvist wrote:
> Remove the function BSP_set_clock_mmss() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, I'll add it to the m68knommu git tree.
Regards
Greg
> ---
> arch/m68k/68360/config.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/m68k/68360/config.c b/arch/m68k/68360/config.c
> index 17ec416..fd1f948 100644
> --- a/arch/m68k/68360/config.c
> +++ b/arch/m68k/68360/config.c
> @@ -106,19 +106,6 @@ void hw_timer_init(irq_handler_t handler)
> pquicc->timer_tgcr = tgcr_save;
> }
>
> -int BSP_set_clock_mmss(unsigned long nowtime)
> -{
> -#if 0
> - short real_seconds = nowtime % 60, real_minutes = (nowtime / 60) % 60;
> -
> - tod->second1 = real_seconds / 10;
> - tod->second2 = real_seconds % 10;
> - tod->minute1 = real_minutes / 10;
> - tod->minute2 = real_minutes % 10;
> -#endif
> - return 0;
> -}
> -
> void BSP_reset (void)
> {
> local_irq_disable();
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-05 0:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-02 21:05 [PATCH] arch: m68k: 68360: config: Remove unused function Rickard Strandqvist
2015-01-02 21:05 ` Rickard Strandqvist
2015-01-05 0:29 ` Greg Ungerer
2015-01-05 0:29 ` Greg Ungerer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.