* [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
@ 2015-01-05 9:14 ` Pankaj Dubey
0 siblings, 0 replies; 6+ messages in thread
From: Pankaj Dubey @ 2015-01-05 9:14 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc; +Cc: kgene, thomas.ab, Pankaj Dubey
Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
of mapping of exynos5440 PMU register which will result in kernel panic
on exynos5440.
As exynos5440 DTS does not have PMU node, and also we are skipping
exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
Reported-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
arch/arm/mach-exynos/exynos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index c13d083..1891b8c 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
* DT is not unflatten so we can't use DT APIs before
* init_irq
*/
- exynos_map_pmu();
+ if (!of_machine_is_compatible("samsung,exynos5440"))
+ exynos_map_pmu();
}
static void __init exynos_dt_machine_init(void)
--
2.2.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
@ 2015-01-05 9:14 ` Pankaj Dubey
0 siblings, 0 replies; 6+ messages in thread
From: Pankaj Dubey @ 2015-01-05 9:14 UTC (permalink / raw)
To: linux-arm-kernel
Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
of mapping of exynos5440 PMU register which will result in kernel panic
on exynos5440.
As exynos5440 DTS does not have PMU node, and also we are skipping
exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
Reported-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
arch/arm/mach-exynos/exynos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index c13d083..1891b8c 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
* DT is not unflatten so we can't use DT APIs before
* init_irq
*/
- exynos_map_pmu();
+ if (!of_machine_is_compatible("samsung,exynos5440"))
+ exynos_map_pmu();
}
static void __init exynos_dt_machine_init(void)
--
2.2.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
2015-01-05 9:14 ` Pankaj Dubey
@ 2015-01-05 9:52 ` Sjoerd Simons
-1 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-05 9:52 UTC (permalink / raw)
To: Pankaj Dubey; +Cc: linux-arm-kernel, linux-samsung-soc, kgene, thomas.ab
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
On Mon, 2015-01-05 at 14:44 +0530, Pankaj Dubey wrote:
> Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
> of mapping of exynos5440 PMU register which will result in kernel panic
> on exynos5440.
>
> As exynos5440 DTS does not have PMU node, and also we are skipping
> exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
> Reported-by: Ming Lei <tom.leiming@gmail.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index c13d083..1891b8c 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
> * DT is not unflatten so we can't use DT APIs before
> * init_irq
> */
> - exynos_map_pmu();
> + if (!of_machine_is_compatible("samsung,exynos5440"))
> + exynos_map_pmu();
> }
>
> static void __init exynos_dt_machine_init(void)
Why the blacklist approach rather then simply making exynos_map_pmu exit
rather then panicing if it couldn't find a pmu node in the dts?
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
@ 2015-01-05 9:52 ` Sjoerd Simons
0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-05 9:52 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2015-01-05 at 14:44 +0530, Pankaj Dubey wrote:
> Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
> of mapping of exynos5440 PMU register which will result in kernel panic
> on exynos5440.
>
> As exynos5440 DTS does not have PMU node, and also we are skipping
> exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
> Reported-by: Ming Lei <tom.leiming@gmail.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> index c13d083..1891b8c 100644
> --- a/arch/arm/mach-exynos/exynos.c
> +++ b/arch/arm/mach-exynos/exynos.c
> @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
> * DT is not unflatten so we can't use DT APIs before
> * init_irq
> */
> - exynos_map_pmu();
> + if (!of_machine_is_compatible("samsung,exynos5440"))
> + exynos_map_pmu();
> }
>
> static void __init exynos_dt_machine_init(void)
Why the blacklist approach rather then simply making exynos_map_pmu exit
rather then panicing if it couldn't find a pmu node in the dts?
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150105/72bb9903/attachment.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
2015-01-05 9:52 ` Sjoerd Simons
@ 2015-01-05 10:06 ` Pankaj Dubey
-1 siblings, 0 replies; 6+ messages in thread
From: Pankaj Dubey @ 2015-01-05 10:06 UTC (permalink / raw)
To: Sjoerd Simons; +Cc: linux-arm-kernel, linux-samsung-soc, kgene, thomas.ab
Hi,
On Monday 05 January 2015 03:22 PM, Sjoerd Simons wrote:
> On Mon, 2015-01-05 at 14:44 +0530, Pankaj Dubey wrote:
>> Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
>> of mapping of exynos5440 PMU register which will result in kernel panic
>> on exynos5440.
>>
>> As exynos5440 DTS does not have PMU node, and also we are skipping
>> exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
>
>
>> Reported-by: Ming Lei <tom.leiming@gmail.com>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>> arch/arm/mach-exynos/exynos.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index c13d083..1891b8c 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
>> * DT is not unflatten so we can't use DT APIs before
>> * init_irq
>> */
>> - exynos_map_pmu();
>> + if (!of_machine_is_compatible("samsung,exynos5440"))
>> + exynos_map_pmu();
>> }
>>
>> static void __init exynos_dt_machine_init(void)
>
> Why the blacklist approach rather then simply making exynos_map_pmu exit
> rather then panicing if it couldn't find a pmu node in the dts?
>
exynos_map_pmu is panicking if it fails to iomap PMU, as for most of
exynos SoCs PMU based address is MUST for secondary core bootup in
platsmp.c, but with exynos5440 it is not the same case. In-fact
exynos_pm_init is also bypassed for exynos5440. For the same reason I
adopted this approach rather removing panic from exynos_map_pmu.
Thanks,
Pankaj Dubey
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440
@ 2015-01-05 10:06 ` Pankaj Dubey
0 siblings, 0 replies; 6+ messages in thread
From: Pankaj Dubey @ 2015-01-05 10:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Monday 05 January 2015 03:22 PM, Sjoerd Simons wrote:
> On Mon, 2015-01-05 at 14:44 +0530, Pankaj Dubey wrote:
>> Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care
>> of mapping of exynos5440 PMU register which will result in kernel panic
>> on exynos5440.
>>
>> As exynos5440 DTS does not have PMU node, and also we are skipping
>> exynos_pm_init in case of exynos5440, let's avoid mapping of exynos5440 PMU.
>
>
>> Reported-by: Ming Lei <tom.leiming@gmail.com>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>> arch/arm/mach-exynos/exynos.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
>> index c13d083..1891b8c 100644
>> --- a/arch/arm/mach-exynos/exynos.c
>> +++ b/arch/arm/mach-exynos/exynos.c
>> @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void)
>> * DT is not unflatten so we can't use DT APIs before
>> * init_irq
>> */
>> - exynos_map_pmu();
>> + if (!of_machine_is_compatible("samsung,exynos5440"))
>> + exynos_map_pmu();
>> }
>>
>> static void __init exynos_dt_machine_init(void)
>
> Why the blacklist approach rather then simply making exynos_map_pmu exit
> rather then panicing if it couldn't find a pmu node in the dts?
>
exynos_map_pmu is panicking if it fails to iomap PMU, as for most of
exynos SoCs PMU based address is MUST for secondary core bootup in
platsmp.c, but with exynos5440 it is not the same case. In-fact
exynos_pm_init is also bypassed for exynos5440. For the same reason I
adopted this approach rather removing panic from exynos_map_pmu.
Thanks,
Pankaj Dubey
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-05 10:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-05 9:14 [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440 Pankaj Dubey
2015-01-05 9:14 ` Pankaj Dubey
2015-01-05 9:52 ` Sjoerd Simons
2015-01-05 9:52 ` Sjoerd Simons
2015-01-05 10:06 ` Pankaj Dubey
2015-01-05 10:06 ` Pankaj Dubey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.