From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: geocode: remove unneeded NULL check
Date: Mon, 05 Jan 2015 12:57:35 +0000 [thread overview]
Message-ID: <54AA8A3F.8080800@ti.com> (raw)
In-Reply-To: <1420008938-18423-1-git-send-email-sudipm.mukherjee@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On 31/12/14 08:55, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
> index 2794ba1..9bee874 100644
> --- a/drivers/video/fbdev/geode/gx1fb_core.c
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> release_mem_region(gx1_gx_base() + 0x8300, 0x100);
> }
>
> - if (info) {
> - fb_dealloc_cmap(&info->cmap);
> - framebuffer_release(info);
> - }
> + fb_dealloc_cmap(&info->cmap);
> + framebuffer_release(info);
>
> return ret;
> }
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: <linux-geode@lists.infradead.org>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: geocode: remove unneeded NULL check
Date: Mon, 5 Jan 2015 14:57:35 +0200 [thread overview]
Message-ID: <54AA8A3F.8080800@ti.com> (raw)
In-Reply-To: <1420008938-18423-1-git-send-email-sudipm.mukherjee@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On 31/12/14 08:55, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
> index 2794ba1..9bee874 100644
> --- a/drivers/video/fbdev/geode/gx1fb_core.c
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> release_mem_region(gx1_gx_base() + 0x8300, 0x100);
> }
>
> - if (info) {
> - fb_dealloc_cmap(&info->cmap);
> - framebuffer_release(info);
> - }
> + fb_dealloc_cmap(&info->cmap);
> + framebuffer_release(info);
>
> return ret;
> }
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-05 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 6:55 [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
2014-12-31 6:55 ` Sudip Mukherjee
2015-01-05 12:57 ` Tomi Valkeinen [this message]
2015-01-05 12:57 ` Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 12:57 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
2015-01-06 12:45 ` [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
2015-01-06 12:57 ` Sudip Mukherjee
2015-01-13 11:31 ` Tomi Valkeinen
2015-01-13 11:31 ` Tomi Valkeinen
2015-02-01 5:05 ` deloptes
2015-02-02 15:13 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA8A3F.8080800@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.