Re: [PATCH:intel-gpu-tools 1/7] Fix #ifdef check for _SC_AVPHYS_PAGES in intel_get_avail_ram_mb()

Re: [PATCH:intel-gpu-tools 1/7] Fix #ifdef check for _SC_AVPHYS_PAGES in intel_get_avail_ram_mb()

[Daniel Vetter]

On Tue, Dec 23, 2014 at 07:07:08PM -0800, Alan Coopersmith wrote:
> Check for the sysconf value used here, not the one used in the
> previous function.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Thanks for the patches, all merged. Aside: Do you really run all the
testcases on solaris or wouldn't it be better to just disable them?
And please cc intel-gfx for igt patches and Thomas Wood (who's doing
maintainer duties for it now) in the future.

Thanks, Daniel

> ---
>  lib/intel_os.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_os.c b/lib/intel_os.c
> index db7889b..1badd3e 100644
> --- a/lib/intel_os.c
> +++ b/lib/intel_os.c
> @@ -112,7 +112,7 @@ intel_get_avail_ram_mb(void)
>
>   retval = sysinf.freeram;
>   retval *= sysinf.mem_unit;
> -#elif defined(_SC_PAGESIZE) && defined(_SC_PHYS_PAGES) /* Solaris */
> +#elif defined(_SC_PAGESIZE) && defined(_SC_AVPHYS_PAGES) /* Solaris */
>   long pagesize, npages;
>
>   pagesize = sysconf(_SC_PAGESIZE);
> --
> 1.7.9.2
>

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH:intel-gpu-tools 1/7] Fix #ifdef check for _SC_AVPHYS_PAGES in intel_get_avail_ram_mb()

[Alan Coopersmith]

On 01/ 5/15 08:11 AM, Daniel Vetter wrote:
> On Tue, Dec 23, 2014 at 07:07:08PM -0800, Alan Coopersmith wrote:
>> Check for the sysconf value used here, not the one used in the
>> previous function.
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
>
> Thanks for the patches, all merged. Aside: Do you really run all the
> testcases on solaris or wouldn't it be better to just disable them?
> And please cc intel-gfx for igt patches and Thomas Wood (who's doing
> maintainer duties for it now) in the future.

Thanks - and I'm not actually sure which of the tests our intel driver
porting team run on Solaris, I was just trying to reduce the number of
bits that failed to build altogether.  (Though I'm sure some that build
will fail at runtime since they won't be able to open files in debugfs
on Solaris.)

-- 
	-Alan Coopersmith-              alan.coopersmith@oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH:intel-gpu-tools 1/7] Fix #ifdef check for _SC_AVPHYS_PAGES in intel_get_avail_ram_mb()

[randyf]

On Mon, 5 Jan 2015, Alan Coopersmith wrote:

> On 01/ 5/15 08:11 AM, Daniel Vetter wrote:
>> On Tue, Dec 23, 2014 at 07:07:08PM -0800, Alan Coopersmith wrote:
>>> Check for the sysconf value used here, not the one used in the
>>> previous function.
>>> 
>>> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
>> 
>> Thanks for the patches, all merged. Aside: Do you really run all the
>> testcases on solaris or wouldn't it be better to just disable them?
>> And please cc intel-gfx for igt patches and Thomas Wood (who's doing
>> maintainer duties for it now) in the future.
>
> Thanks - and I'm not actually sure which of the tests our intel driver
> porting team run on Solaris, I was just trying to reduce the number of
> bits that failed to build altogether.  (Though I'm sure some that build
> will fail at runtime since they won't be able to open files in debugfs
> on Solaris.)
>


   We don't run any of the tests in intel-gpu-tools due to various 
incompatibilities, and currently opt for a small set of "sanity" tests 
that are specific to Solaris.

   There was an intent to investigate these tests more closely once we
had a stable environment, but haven't yet undertaken that task (mostly
due to the limited resources available to do the work).  A couple of
the tools themselves have been quite useful, though.


         ---- Randy


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx