All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [review-request] adamian/20141216-projectpage-6587
Date: Tue, 06 Jan 2015 18:49:53 +0000	[thread overview]
Message-ID: <54AC2E51.2060803@intel.com> (raw)
In-Reply-To: <CAJ2CSBvimUHP3uftbki0WyTwLsHTGYP2TY8mf3JDdibO_RGjYw@mail.gmail.com>

Code looks ok, would be good to get the "[review-request][PATCH] 
bitbake: toaster: Improve client side error handling" patch in first and 
then make use of that for logging.

Thanks,

Michael


On 06/01/15 16:58, Damian, Alexandru wrote:
> Hello,
>
> I pushed the latest changes to the Project page here.
>
> adamian/20141216-projectpage-6587
>
> This should bring the project page in line with the design, except for 
> error handling in the "invalid machine" and "invalid distro" cases - 
> only "missing target" error handling is present.
>
> Can you please review the code and let me know if I can push ?
>
> Cheers,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>



  reply	other threads:[~2015-01-06 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 16:58 [review-request] adamian/20141216-projectpage-6587 Damian, Alexandru
2015-01-06 18:49 ` Michael Wood [this message]
2015-01-07 10:35   ` Damian, Alexandru
2015-01-07  9:31 ` Barros Pena, Belen
2015-01-07 10:35   ` Damian, Alexandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AC2E51.2060803@intel.com \
    --to=michael.g.wood@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.