All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Daniel Borkmann <dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Will Drewry <wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org
Subject: Re: Edited seccomp.2 man page for review [v2]
Date: Wed, 07 Jan 2015 13:41:39 +0100	[thread overview]
Message-ID: <54AD2983.2060108@gmail.com> (raw)
In-Reply-To: <54AD2549.9040107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 01/07/2015 01:23 PM, Daniel Borkmann wrote:
> On 01/07/2015 12:53 PM, Michael Kerrisk (man-pages) wrote:
> ...
>> Still hoping to hear from Will Drewy regarding this FIXME in the
>> page source:
>>
>> .\" FIXME What is the significance of the line
>> .\"           ftest->code = BPF_LDX | BPF_W | BPF_ABS;
>> .\"       in kernel/seccomp.c::seccomp_check_filter()?
> 
> This came in from our rework via commit bd4cf0ed331a ("net: filter:
> rework/optimize internal BPF interpreter's instruction set"), and
> is kernel-internal only, and unused in classic BPF. It translates
> into A = *(u32 *) (ctx + K) and will basically load an offset from
> the populated seccomp_data (= ctx) to A. For the man-page itself
> it has therefore no relevance, hope that clarifies it.

Thanks, Daniel.

Okay -- that was the last hurdle. The page should go out with the 
next man-pages release.

Cheers,

Michael




-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: mtk.manpages@gmail.com, Kees Cook <keescook@chromium.org>,
	Linux API <linux-api@vger.kernel.org>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Will Drewry <wad@chromium.org>,
	ast@plumgrid.com
Subject: Re: Edited seccomp.2 man page for review [v2]
Date: Wed, 07 Jan 2015 13:41:39 +0100	[thread overview]
Message-ID: <54AD2983.2060108@gmail.com> (raw)
In-Reply-To: <54AD2549.9040107@redhat.com>

On 01/07/2015 01:23 PM, Daniel Borkmann wrote:
> On 01/07/2015 12:53 PM, Michael Kerrisk (man-pages) wrote:
> ...
>> Still hoping to hear from Will Drewy regarding this FIXME in the
>> page source:
>>
>> .\" FIXME What is the significance of the line
>> .\"           ftest->code = BPF_LDX | BPF_W | BPF_ABS;
>> .\"       in kernel/seccomp.c::seccomp_check_filter()?
> 
> This came in from our rework via commit bd4cf0ed331a ("net: filter:
> rework/optimize internal BPF interpreter's instruction set"), and
> is kernel-internal only, and unused in classic BPF. It translates
> into A = *(u32 *) (ctx + K) and will basically load an offset from
> the populated seccomp_data (= ctx) to A. For the man-page itself
> it has therefore no relevance, hope that clarifies it.

Thanks, Daniel.

Okay -- that was the last hurdle. The page should go out with the 
next man-pages release.

Cheers,

Michael




-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  parent reply	other threads:[~2015-01-07 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 12:14 Edited seccomp.2 man page for review [v2] Michael Kerrisk (man-pages)
2014-12-30 12:14 ` Michael Kerrisk (man-pages)
     [not found] ` <54A29722.1010901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-30 17:16   ` Kees Cook
2014-12-30 17:16     ` Kees Cook
     [not found]     ` <CAGXu5j+C0SWQ+CeOb2ADXdsLWorUHahX4UhUg+UGbT6UuWiQFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-30 19:45       ` Michael Kerrisk (man-pages)
2014-12-30 19:45         ` Michael Kerrisk (man-pages)
     [not found]         ` <54A300D0.7090802-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 20:25           ` Kees Cook
2015-01-05 20:25             ` Kees Cook
     [not found]             ` <CAGXu5jKCR8ft=2XNX+SsCOokEqCt9sZizKj4wfAGrXVzf6adcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-07 11:53               ` Michael Kerrisk (man-pages)
2015-01-07 11:53                 ` Michael Kerrisk (man-pages)
     [not found]                 ` <54AD1E37.8020509-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-07 12:23                   ` Daniel Borkmann
2015-01-07 12:23                     ` Daniel Borkmann
     [not found]                     ` <54AD2549.9040107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-01-07 12:41                       ` Michael Kerrisk (man-pages) [this message]
2015-01-07 12:41                         ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD2983.2060108@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org \
    --cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.