From: Bob Cochran <yocto@mindchasers.com>
To: ting.liu@freescale.com, meta-freescale@yoctoproject.org
Subject: Re: [meta-fsl-ppc][PATCH 12/12] multilib: use ?= to allow overridden in local.conf
Date: Wed, 07 Jan 2015 10:12:40 -0500 [thread overview]
Message-ID: <54AD4CE8.5080401@mindchasers.com> (raw)
In-Reply-To: <1420605208-3545-13-git-send-email-ting.liu@freescale.com>
This patch does not apply properly. See below plus a comment on commit
log...
On 01/06/2015 11:33 PM, ting.liu@freescale.com wrote:
> From: Ting Liu <ting.liu@freescale.com>
>
> the multilib setting have already been moved to the machine
> configure file.
I'm not sure what you mean. Aren't the machine config files the ones in
"meta-fsl-ppc/conf/machine" MULTILIBS is not set in any of machine conf
files (e.g., t1040rdb-64b.conf). The only conf files I see MULTILIBS
being used are in the e5500 and e6500 include files.
according to the including order in bitbake.conf
> the machine configure file is after local.conf file.so the value
> in local.conf will be overridden. change to use ?=.
>
> This is useful when using external toolchain which does not need
> to enable multilib.
>
> Signed-off-by: Zongchun Yu <Zongchun.Yu@freescale.com>
> ---
> conf/machine/include/e5500-64b.inc | 4 ++--
> conf/machine/include/e6500-64b.inc | 4 ++--
> conf/machine/include/e6500.inc | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/conf/machine/include/e5500-64b.inc b/conf/machine/include/e5500-64b.inc
> index a8b69dd..d6d3cfd 100644
> --- a/conf/machine/include/e5500-64b.inc
> +++ b/conf/machine/include/e5500-64b.inc
> @@ -7,7 +7,7 @@ require conf/machine/include/qoriq-base.inc
> MACHINEOVERRIDES .= ":e5500-64b"
>
> require conf/multilib.conf
> -MULTILIBS = "multilib:lib32"
> -DEFAULTTUNE_virtclass-multilib-lib32 = "ppce5500"
> +MULTILIBS ?= "multilib:lib32"
> +DEFAULTTUNE_virtclass-multilib-lib32 ?= "ppce5500"
> USER_CLASSES_remove = "image-prelink"
I'm seeing errors when applying this patch. I don't see a
"USER_CLASSES_remove = "image-prelink" line in these conf files.
>
> diff --git a/conf/machine/include/e6500-64b.inc b/conf/machine/include/e6500-64b.inc
> index 6b7297b..f98f402 100644
> --- a/conf/machine/include/e6500-64b.inc
> +++ b/conf/machine/include/e6500-64b.inc
> @@ -7,7 +7,7 @@ require conf/machine/include/qoriq-base.inc
> MACHINEOVERRIDES .= ":e6500-64b"
>
> require conf/multilib.conf
> -MULTILIBS = "multilib:lib32"
> -DEFAULTTUNE_virtclass-multilib-lib32 = "ppce6500"
> +MULTILIBS ?= "multilib:lib32"
> +DEFAULTTUNE_virtclass-multilib-lib32 ?= "ppce6500"
> USER_CLASSES_remove = "image-prelink"
Line doesn't exist
>
> diff --git a/conf/machine/include/e6500.inc b/conf/machine/include/e6500.inc
> index e6848bd..4121fbe 100644
> --- a/conf/machine/include/e6500.inc
> +++ b/conf/machine/include/e6500.inc
> @@ -8,6 +8,6 @@ MACHINEOVERRIDES .= ":e6500"
> BUILD_64BIT_KERNEL = "1"
>
> require conf/multilib.conf
> -MULTILIBS = "multilib:lib64"
> -DEFAULTTUNE_virtclass-multilib-lib64 = "ppc64e6500"
> +MULTILIBS ?= "multilib:lib64"
> +DEFAULTTUNE_virtclass-multilib-lib64 ?= "ppc64e6500"
>
>
next prev parent reply other threads:[~2015-01-07 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 4:33 [meta-fsl-ppc][PATCH 00/12] qoriq sdk v1.7 patches (part II) ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 01/12] t1024qds-64b: add machine support ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 02/12] t1024qds: " ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 03/12] t1024rdb: " ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 04/12] t1024rdb-64b: " ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 05/12] qemu: remove unavailable gtk+ options ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 06/12] skmm-ep: update revision to 27156a6 ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 07/12] fm-ucode: use soc_family to match deployed binaries ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 08/12] fm-ucode: update to revision 4cda2e3 ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 09/12] usdpaa: use soc_family to define SOC/FMAN_VARIANT ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 10/12] usdpaa: update to revision d997594 ting.liu
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 11/12] uio-seville: update to revision 35af73f ting.liu
2015-01-08 10:09 ` zhenhua.luo
2015-01-07 4:33 ` [meta-fsl-ppc][PATCH 12/12] multilib: use ?= to allow overridden in local.conf ting.liu
2015-01-07 15:12 ` Bob Cochran [this message]
2015-01-08 2:37 ` ting.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD4CE8.5080401@mindchasers.com \
--to=yocto@mindchasers.com \
--cc=meta-freescale@yoctoproject.org \
--cc=ting.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.