From: Timur Tabi <timur@tabi.org>
To: Fabio Estevam <festevam@gmail.com>, broonie@kernel.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference
Date: Wed, 07 Jan 2015 11:26:44 -0600 [thread overview]
Message-ID: <54AD6C54.4090709@tabi.org> (raw)
In-Reply-To: <1420651312-21671-2-git-send-email-festevam@gmail.com>
Fabio Estevam wrote:
> - ssi_np->full_name);
> + pdev->name);
> of_node_put(ssi_np);
> return ret;
> }
>
> - dma = kzalloc(sizeof(*dma) + strlen(np->full_name), GFP_KERNEL);
> + dma = kzalloc(sizeof(*dma), GFP_KERNEL);
Something is missing here. Since we're no longer allocating space in
the 'dma' object for the name, then you should probably delete the code
that copies the string to the 'dma' object.
next prev parent reply other threads:[~2015-01-07 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:21 [PATCH 1/2] ASoC: fsl_dma: Remove 'path' field from dma_object struct Fabio Estevam
2015-01-07 17:21 ` [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference Fabio Estevam
2015-01-07 17:26 ` Timur Tabi [this message]
2015-01-07 17:26 ` Lars-Peter Clausen
2015-01-07 17:27 ` Timur Tabi
2015-01-07 17:47 ` Fabio Estevam
2015-01-07 17:54 ` Timur Tabi
2015-01-07 17:23 ` [PATCH 1/2] ASoC: fsl_dma: Remove 'path' field from dma_object struct Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD6C54.4090709@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.