From: Timur Tabi <timur@tabi.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Mark Brown <broonie@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference
Date: Wed, 07 Jan 2015 11:54:07 -0600 [thread overview]
Message-ID: <54AD72BF.20805@tabi.org> (raw)
In-Reply-To: <CAOMZO5Cuq0ejHGOqE0W=-=qU-P_=qruKqzHxcVGkFpmEhydC8Q@mail.gmail.com>
Fabio Estevam wrote:
> - dev_err(&pdev->dev, "could not determine resources for %s\n",
> - ssi_np->full_name);
> + dev_err(&pdev->dev, "could not determine resources: %d\n", ret);
I remember now why I did this, and I might need to NACK this patch.
ssi_np->full_name is the name of the SSI node, but here, dev_err will
print the name of the DMA node. So the intent is to help the user
determine which SSI node has a broken DMA node pointer. This probably
is useful only on PowerPC, which uses the old ssi->dma linkage.
next prev parent reply other threads:[~2015-01-07 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:21 [PATCH 1/2] ASoC: fsl_dma: Remove 'path' field from dma_object struct Fabio Estevam
2015-01-07 17:21 ` [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference Fabio Estevam
2015-01-07 17:26 ` Timur Tabi
2015-01-07 17:26 ` Lars-Peter Clausen
2015-01-07 17:27 ` Timur Tabi
2015-01-07 17:47 ` Fabio Estevam
2015-01-07 17:54 ` Timur Tabi [this message]
2015-01-07 17:23 ` [PATCH 1/2] ASoC: fsl_dma: Remove 'path' field from dma_object struct Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD72BF.20805@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.