Re: [PATCH 3/3] mtd: spi-nand: add devicetree binding

[Ezequiel Garcia <ezequiel.garcia@imgtec.com>]

On 01/07/2015 09:52 PM, Peter Pan 潘栋 (peterpandong) wrote:
> This commit adds the devicetree binding document that specifies the
> spi nand devices support.
> 
> Signed-off-by: Peter Pan <peterpandong@micron.com>
> ---
>  Documentation/devicetree/bindings/mtd/spi-nand.txt | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> new file mode 100644
> index 0000000..9dd3efd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> @@ -0,0 +1,22 @@
> +* NAND driver for MT29F, GD5F and similar SPI NAND flash chips
> +
> +Required properties:
> +- #address-cells, #size-cells : Must be present if the device has sub-nodes
> +  representing partitions.
> +- compatible : Should be the manufacturer and the name of the chip. Bear in mind
> 

Unless I'm mistaken, we don't need the chip ID here, as SPI NAND allows
to autodetect the device. Any reason why we can't just use a generic
compatible "spi-nand" here?
-- 
Ezequiel