Re: [PATCH 3/3] mtd: spi-nand: add devicetree binding

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Thu, Jan 08, 2015 at 12:52:26AM +0000, Peter Pan 潘栋 (peterpandong) wrote:
> This commit adds the devicetree binding document that specifies the
> spi nand devices support.
> 
> Signed-off-by: Peter Pan <peterpandong-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mtd/spi-nand.txt | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> new file mode 100644
> index 0000000..9dd3efd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> @@ -0,0 +1,22 @@
> +* NAND driver for MT29F, GD5F and similar SPI NAND flash chips
> +
> +Required properties:
> +- #address-cells, #size-cells : Must be present if the device has sub-nodes
> +  representing partitions.

Can we refer to the binding document for that?

> +- compatible : Should be the manufacturer and the name of the chip. Bear in mind
> +               the DT binding is not Linux-only, but in case of Linux, see the
> +               "spi_nand_id_table" array in drivers/mtd/spi-nand/spi-nand-device.c
> +               for the list of supported chips.

NAK for referring to Linux internals from a binding document.

The list of compatible string should be defined in this binding
document.

> +- reg : Chip-Select number
> +- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
> +
> +Example:
> +
> +	flash: flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;

These aren't necessary as no partitions are defined here.

Otherwise, this looks ok.

Thanks,
Mark.

> +		compatible = "micron,mt29f";
> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +	};
> +
> -- 
> 1.9.1
> N嫥叉靣笡y氊b瞂千v豝?藓{.n?壏漽鴾z谵z)韰骅w*\x1fjg?秹殠娸/侁鋤罐枈?娹櫒璀??摺玜囤\x7f\x1e瓽珴閔?鎗:+v墾妛鑶佶
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html