From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 3/4] dt-uart: use ':' as separator between path and options
Date: Thu, 08 Jan 2015 12:26:31 +0000 [thread overview]
Message-ID: <54AE7777.8090204@linaro.org> (raw)
In-Reply-To: <1420718036-29651-3-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 08/01/15 11:53, Ian Campbell wrote:
> diff --git a/xen/drivers/char/dt-uart.c b/xen/drivers/char/dt-uart.c
> index 04dbb97..b9a0956 100644
> --- a/xen/drivers/char/dt-uart.c
> +++ b/xen/drivers/char/dt-uart.c
> @@ -31,7 +31,7 @@
> * doesn't start with '/', we assuming that it's an alias.
> * @options: UART speficic options (see in each UART driver)
> */
You forgot to modify the comment:
"Configure UART port with a string:
path,options"
With this change:
Reviewed-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-01-08 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 11:53 [PATCH v2 0/4] dt-uart: cleanups, bugfixes and /chosen/stdout-path support Ian Campbell
2015-01-08 11:53 ` [PATCH v2 1/4] dt-uart: add an emacs magic block Ian Campbell
2015-01-08 11:53 ` [PATCH v2 2/4] dt-uart: Clarify log messages at init time Ian Campbell
2015-01-08 11:53 ` [PATCH v2 3/4] dt-uart: use ':' as separator between path and options Ian Campbell
2015-01-08 12:26 ` Julien Grall [this message]
2015-01-08 12:29 ` Ian Campbell
2015-01-08 11:53 ` [PATCH v2 4/4] dt-uart: support /chosen/stdout-path property Ian Campbell
2015-01-08 13:15 ` Julien Grall
2015-01-08 13:22 ` Ian Campbell
2015-01-08 13:30 ` Julien Grall
2015-01-12 15:22 ` Ian Campbell
2015-01-12 15:24 ` Julien Grall
2015-01-12 16:31 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE7777.8090204@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.