From: Stephen Boyd <sboyd@codeaurora.org>
To: Andy Gross <agross@codeaurora.org>, linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] soc: qcom: Add TCSR driver
Date: Thu, 08 Jan 2015 15:39:44 -0800 [thread overview]
Message-ID: <54AF1540.6090800@codeaurora.org> (raw)
In-Reply-To: <1420757577-20425-2-git-send-email-agross@codeaurora.org>
On 01/08/2015 02:52 PM, Andy Gross wrote:
> +
> +static struct platform_driver qcom_tcsr_driver = {
> + .driver = {
> + .name = "tcsr",
> + .owner = THIS_MODULE,
This is done by the module_platform_driver() macro now so it's largely
unnecessary. Best to remove it so that the janitors don't find you!
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] soc: qcom: Add TCSR driver
Date: Thu, 08 Jan 2015 15:39:44 -0800 [thread overview]
Message-ID: <54AF1540.6090800@codeaurora.org> (raw)
In-Reply-To: <1420757577-20425-2-git-send-email-agross@codeaurora.org>
On 01/08/2015 02:52 PM, Andy Gross wrote:
> +
> +static struct platform_driver qcom_tcsr_driver = {
> + .driver = {
> + .name = "tcsr",
> + .owner = THIS_MODULE,
This is done by the module_platform_driver() macro now so it's largely
unnecessary. Best to remove it so that the janitors don't find you!
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-08 23:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 22:52 [PATCH 0/2] Add Qualcomm TCSR driver Andy Gross
2015-01-08 22:52 ` Andy Gross
2015-01-08 22:52 ` [PATCH 1/2] soc: qcom: Add " Andy Gross
2015-01-08 22:52 ` Andy Gross
2015-01-08 23:39 ` Stephen Boyd [this message]
2015-01-08 23:39 ` Stephen Boyd
[not found] ` <54AF1540.6090800-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-01-09 17:10 ` Andy Gross
2015-01-09 17:10 ` Andy Gross
2015-01-09 17:10 ` Andy Gross
[not found] ` <1420757577-20425-2-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-01-09 0:06 ` Arnd Bergmann
2015-01-09 0:06 ` Arnd Bergmann
2015-01-09 0:06 ` Arnd Bergmann
2015-01-09 17:13 ` Andy Gross
2015-01-09 17:13 ` Andy Gross
2015-01-09 17:13 ` Andy Gross
2015-01-09 18:31 ` Bjorn Andersson
2015-01-09 18:31 ` Bjorn Andersson
2015-01-08 22:52 ` [PATCH 2/2] soc: qcom: Add device tree binding for TCSR Andy Gross
2015-01-08 22:52 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AF1540.6090800@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.