All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/7] Fix sti drivers whcih mix reg address spaces
Date: Fri, 9 Jan 2015 13:45:06 +0100	[thread overview]
Message-ID: <54AFCD52.4050302@st.com> (raw)
In-Reply-To: <1420643052-4506-1-git-send-email-peter.griffin@linaro.org>

Hi Peter,

On 01/07/2015 04:04 PM, Peter Griffin wrote:
> Hi folks,
>
> A V2 of this old series incorporating Arnd and Lees Feedback form v1.
>
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair
> (where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
>
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable.
>
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.
>
> regards,
>
> Peter.
>
> Changes since v1:
> - Add missing space after */ (Lee)
> - Change comment to "indexed from" rather than "not indexed from" (Lee)
> - Change naming to phy1, phy2 rather than phy at 1 phy at 2 if there is no reg property (Arnd / Grant)
> - Rebased on v3.19-rc3 (me)
> - Checkpatch "no space before tabs" warning in stih41*.dtsi (me)
>
> Peter Griffin (7):
>    phy: phy-stih407-usb: Pass sysconfig register offsets via syscfg
>      property.
>    phy: miphy365x: Pass sysconfig register offsets via syscfg dt
>      property.
>    ARM: STi: DT: STiH407: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add DT nodes for the ehci and ohci usb
>      controllers.
>    ARM: multi_v7_defconfig: Enable stih407 usb picophy
>    stmmac: dwmac-sti: Pass sysconfig register offset via syscon dt
>      property.
>
>   .../devicetree/bindings/net/sti-dwmac.txt          | 14 ++---
>   .../devicetree/bindings/phy/phy-miphy365x.txt      | 15 ++---
>   .../devicetree/bindings/phy/phy-stih407-usb.txt    | 10 +---
>   arch/arm/boot/dts/stih407-family.dtsi              |  9 +++
>   arch/arm/boot/dts/stih410.dtsi                     | 70 ++++++++++++++++++++++
>   arch/arm/boot/dts/stih415.dtsi                     | 12 ++--
>   arch/arm/boot/dts/stih416.dtsi                     | 22 +++----
>   arch/arm/configs/multi_v7_defconfig                |  1 +
>   drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c    | 13 ++--
>   drivers/phy/phy-miphy365x.c                        | 29 ++++-----
>   drivers/phy/phy-stih407-usb.c                      | 25 ++++----
>   11 files changed, 143 insertions(+), 77 deletions(-)
>

Thanks! The series looks good to me.

DT patches applied to sti-dt-for-v3.20 branch,
and defconfig patch applied to sti-defconfig-for-v3.20.


Regards,
Maxime

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	patrice.chotard@st.com, peppe.cavallaro@st.com, kishon@ti.com,
	arnd@arndb.de
Cc: lee.jones@linaro.org, devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Fix sti drivers whcih mix reg address spaces
Date: Fri, 9 Jan 2015 13:45:06 +0100	[thread overview]
Message-ID: <54AFCD52.4050302@st.com> (raw)
In-Reply-To: <1420643052-4506-1-git-send-email-peter.griffin@linaro.org>

Hi Peter,

On 01/07/2015 04:04 PM, Peter Griffin wrote:
> Hi folks,
>
> A V2 of this old series incorporating Arnd and Lees Feedback form v1.
>
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair
> (where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
>
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable.
>
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.
>
> regards,
>
> Peter.
>
> Changes since v1:
> - Add missing space after */ (Lee)
> - Change comment to "indexed from" rather than "not indexed from" (Lee)
> - Change naming to phy1, phy2 rather than phy@1 phy@2 if there is no reg property (Arnd / Grant)
> - Rebased on v3.19-rc3 (me)
> - Checkpatch "no space before tabs" warning in stih41*.dtsi (me)
>
> Peter Griffin (7):
>    phy: phy-stih407-usb: Pass sysconfig register offsets via syscfg
>      property.
>    phy: miphy365x: Pass sysconfig register offsets via syscfg dt
>      property.
>    ARM: STi: DT: STiH407: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add DT nodes for the ehci and ohci usb
>      controllers.
>    ARM: multi_v7_defconfig: Enable stih407 usb picophy
>    stmmac: dwmac-sti: Pass sysconfig register offset via syscon dt
>      property.
>
>   .../devicetree/bindings/net/sti-dwmac.txt          | 14 ++---
>   .../devicetree/bindings/phy/phy-miphy365x.txt      | 15 ++---
>   .../devicetree/bindings/phy/phy-stih407-usb.txt    | 10 +---
>   arch/arm/boot/dts/stih407-family.dtsi              |  9 +++
>   arch/arm/boot/dts/stih410.dtsi                     | 70 ++++++++++++++++++++++
>   arch/arm/boot/dts/stih415.dtsi                     | 12 ++--
>   arch/arm/boot/dts/stih416.dtsi                     | 22 +++----
>   arch/arm/configs/multi_v7_defconfig                |  1 +
>   drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c    | 13 ++--
>   drivers/phy/phy-miphy365x.c                        | 29 ++++-----
>   drivers/phy/phy-stih407-usb.c                      | 25 ++++----
>   11 files changed, 143 insertions(+), 77 deletions(-)
>

Thanks! The series looks good to me.

DT patches applied to sti-dt-for-v3.20 branch,
and defconfig patch applied to sti-defconfig-for-v3.20.


Regards,
Maxime

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <srinivas.kandagatla@gmail.com>,
	<patrice.chotard@st.com>, <peppe.cavallaro@st.com>,
	<kishon@ti.com>, <arnd@arndb.de>
Cc: <lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v2 0/7] Fix sti drivers whcih mix reg address spaces
Date: Fri, 9 Jan 2015 13:45:06 +0100	[thread overview]
Message-ID: <54AFCD52.4050302@st.com> (raw)
In-Reply-To: <1420643052-4506-1-git-send-email-peter.griffin@linaro.org>

Hi Peter,

On 01/07/2015 04:04 PM, Peter Griffin wrote:
> Hi folks,
>
> A V2 of this old series incorporating Arnd and Lees Feedback form v1.
>
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair
> (where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
>
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable.
>
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.
>
> regards,
>
> Peter.
>
> Changes since v1:
> - Add missing space after */ (Lee)
> - Change comment to "indexed from" rather than "not indexed from" (Lee)
> - Change naming to phy1, phy2 rather than phy@1 phy@2 if there is no reg property (Arnd / Grant)
> - Rebased on v3.19-rc3 (me)
> - Checkpatch "no space before tabs" warning in stih41*.dtsi (me)
>
> Peter Griffin (7):
>    phy: phy-stih407-usb: Pass sysconfig register offsets via syscfg
>      property.
>    phy: miphy365x: Pass sysconfig register offsets via syscfg dt
>      property.
>    ARM: STi: DT: STiH407: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add usb2 picophy dt nodes
>    ARM: STi: DT: STiH410: Add DT nodes for the ehci and ohci usb
>      controllers.
>    ARM: multi_v7_defconfig: Enable stih407 usb picophy
>    stmmac: dwmac-sti: Pass sysconfig register offset via syscon dt
>      property.
>
>   .../devicetree/bindings/net/sti-dwmac.txt          | 14 ++---
>   .../devicetree/bindings/phy/phy-miphy365x.txt      | 15 ++---
>   .../devicetree/bindings/phy/phy-stih407-usb.txt    | 10 +---
>   arch/arm/boot/dts/stih407-family.dtsi              |  9 +++
>   arch/arm/boot/dts/stih410.dtsi                     | 70 ++++++++++++++++++++++
>   arch/arm/boot/dts/stih415.dtsi                     | 12 ++--
>   arch/arm/boot/dts/stih416.dtsi                     | 22 +++----
>   arch/arm/configs/multi_v7_defconfig                |  1 +
>   drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c    | 13 ++--
>   drivers/phy/phy-miphy365x.c                        | 29 ++++-----
>   drivers/phy/phy-stih407-usb.c                      | 25 ++++----
>   11 files changed, 143 insertions(+), 77 deletions(-)
>

Thanks! The series looks good to me.

DT patches applied to sti-dt-for-v3.20 branch,
and defconfig patch applied to sti-defconfig-for-v3.20.


Regards,
Maxime

  parent reply	other threads:[~2015-01-09 12:45 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 15:04 [PATCH v2 0/7] Fix sti drivers whcih mix reg address spaces Peter Griffin
2015-01-07 15:04 ` Peter Griffin
2015-01-07 15:04 ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 1/7] phy: phy-stih407-usb: Pass sysconfig register offsets via syscfg property Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 2/7] phy: miphy365x: Pass sysconfig register offsets via syscfg dt property Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-30 10:35   ` Kishon Vijay Abraham I
2015-01-30 10:35     ` Kishon Vijay Abraham I
2015-01-30 10:35     ` Kishon Vijay Abraham I
2015-01-30 10:48     ` Maxime Coquelin
2015-01-30 10:48       ` Maxime Coquelin
2015-01-30 10:48       ` Maxime Coquelin
2015-01-30 11:08       ` Kishon Vijay Abraham I
2015-01-30 11:08         ` Kishon Vijay Abraham I
2015-01-30 11:08         ` Kishon Vijay Abraham I
2015-01-30 11:48         ` Maxime Coquelin
2015-01-30 11:48           ` Maxime Coquelin
2015-01-30 11:48           ` Maxime Coquelin
2015-01-30 11:48           ` Maxime Coquelin
2015-01-07 15:04 ` [PATCH v2 3/7] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 4/7] ARM: STi: DT: STiH410: " Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 5/7] ARM: STi: DT: STiH410: Add DT nodes for the ehci and ohci usb controllers Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 6/7] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-07 15:04 ` [PATCH v2 7/7] stmmac: dwmac-sti: Pass sysconfig register offset via syscon dt property Peter Griffin
2015-01-07 15:04   ` Peter Griffin
2015-01-09 12:45 ` Maxime Coquelin [this message]
2015-01-09 12:45   ` [PATCH v2 0/7] Fix sti drivers whcih mix reg address spaces Maxime Coquelin
2015-01-09 12:45   ` Maxime Coquelin
2015-01-11 23:54 ` David Miller
2015-01-11 23:54   ` David Miller
2015-01-11 23:54   ` David Miller
2015-01-14 12:17   ` Maxime Coquelin
2015-01-14 12:17     ` Maxime Coquelin
2015-01-14 12:17     ` Maxime Coquelin
2015-01-14 12:17     ` Maxime Coquelin
2015-01-21  8:54 ` Kishon Vijay Abraham I
2015-01-21  8:54   ` Kishon Vijay Abraham I
2015-01-21  8:54   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AFCD52.4050302@st.com \
    --to=maxime.coquelin@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.