From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Srinivas Pandruvada
<srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
jkosina-AlSwsSmVLrQ@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read
Date: Sat, 10 Jan 2015 22:42:30 +0000 [thread overview]
Message-ID: <54B1AAD6.6070303@kernel.org> (raw)
In-Reply-To: <1420656483-7093-3-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On 07/01/15 18:47, Srinivas Pandruvada wrote:
> The new API added a flag for sync/async mode. Added sync mode flag.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Again, please don't break the build between patches like this.
If you want to do things in steps, you'll have to carry to versions of
the function during the conversion and drop the unwanted one at the end.
> ---
> drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index d5d9531..0085c2f 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
> *val = sensor_hub_input_attr_get_raw_value(
> accel_state->common_attributes.hsdev,
> HID_USAGE_SENSOR_ACCEL_3D, address,
> - report_id);
> + report_id,
> + SENSOR_HUB_SYNC);
> else {
> *val = 0;
> hid_sensor_power_state(&accel_state->common_attributes,
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
jkosina@suse.cz, a.zummo@towertech.it
Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
holler@ahsoftware.de, rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read
Date: Sat, 10 Jan 2015 22:42:30 +0000 [thread overview]
Message-ID: <54B1AAD6.6070303@kernel.org> (raw)
In-Reply-To: <1420656483-7093-3-git-send-email-srinivas.pandruvada@linux.intel.com>
On 07/01/15 18:47, Srinivas Pandruvada wrote:
> The new API added a flag for sync/async mode. Added sync mode flag.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Again, please don't break the build between patches like this.
If you want to do things in steps, you'll have to carry to versions of
the function during the conversion and drop the unwanted one at the end.
> ---
> drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index d5d9531..0085c2f 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
> *val = sensor_hub_input_attr_get_raw_value(
> accel_state->common_attributes.hsdev,
> HID_USAGE_SENSOR_ACCEL_3D, address,
> - report_id);
> + report_id,
> + SENSOR_HUB_SYNC);
> else {
> *val = 0;
> hid_sensor_power_state(&accel_state->common_attributes,
>
next prev parent reply other threads:[~2015-01-10 22:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 18:47 [PATCH 0/9] Asynchronous attribute reads Srinivas Pandruvada
2015-01-07 18:47 ` Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read Srinivas Pandruvada
[not found] ` <1420656483-7093-3-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-10 22:42 ` Jonathan Cameron [this message]
2015-01-10 22:42 ` Jonathan Cameron
2015-01-11 23:08 ` Srinivas Pandruvada
2015-01-11 23:24 ` Srinivas Pandruvada
[not found] ` <54B30610.3070907-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-12 21:24 ` Jonathan Cameron
2015-01-12 21:24 ` Jonathan Cameron
[not found] ` <54B43B70.4070501-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-01-12 21:33 ` Srinivas Pandruvada
2015-01-12 21:33 ` Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 3/9] iio: hid-sensor-gyro-3d: " Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 4/9] iio: hid-sensor-als: " Srinivas Pandruvada
[not found] ` <1420656483-7093-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-07 18:47 ` [PATCH 1/9] HID: hid-sensor-hub: Extend API for async reads Srinivas Pandruvada
2015-01-07 18:47 ` Srinivas Pandruvada
[not found] ` <1420656483-7093-2-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-10 22:43 ` Jonathan Cameron
2015-01-10 22:43 ` Jonathan Cameron
2015-01-07 18:47 ` [PATCH 5/9] iio: hid-sensor-prox: Adjust parameter for attribute read Srinivas Pandruvada
2015-01-07 18:47 ` Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 6/9] iio: hid-sensor-magn-3d: " Srinivas Pandruvada
2015-01-07 18:48 ` Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 8/9] iio: hid-sensor-press: " Srinivas Pandruvada
2015-01-07 18:48 ` Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 9/9] drivers/rtc/rtc-hid-sensor-time.c: " Srinivas Pandruvada
2015-01-07 18:48 ` Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 7/9] iio: hid-sensor-incl-3d: " Srinivas Pandruvada
-- strict thread matches above, loose matches on Subject: below --
2015-01-07 0:58 [PATCH] HID: hid-sensor-hub: Correct documentation Srinivas Pandruvada
[not found] ` <1420592328-9942-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-07 0:58 ` [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read Srinivas Pandruvada
2015-01-07 0:58 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B1AAD6.6070303@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.