* [PATCH] ath9k_htc: Add a module parameter to disable blink
@ 2015-01-11 9:20 Hong Xu
2015-01-11 9:40 ` Arend van Spriel
2015-01-12 6:54 ` Bob Copeland
0 siblings, 2 replies; 10+ messages in thread
From: Hong Xu @ 2015-01-11 9:20 UTC (permalink / raw)
To: linux-wireless; +Cc: Hong Xu
Add an option "blink" to enable or disable the LED blink. The default
value is set to 1 so that existing users would not experience any
unexpected changes.
---
drivers/net/wireless/ath/ath9k/htc.h | 1 +
drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++++
drivers/net/wireless/ath/ath9k/htc_drv_init.c | 4 ++++
3 files changed, 9 insertions(+)
diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index 9dde265..5697097 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -44,6 +44,7 @@
extern struct ieee80211_ops ath9k_htc_ops;
extern int htc_modparam_nohwcrypt;
+extern int led_blink;
enum htc_phymode {
HTC_MODE_11NA = 0,
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
index 50f74a2..998b558 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
@@ -279,6 +279,10 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
else
priv->ah->led_pin = ATH_LED_PIN_DEF;
+ if (!led_blink)
+ priv->led_cdev.default_trigger =
+ ieee80211_get_radio_led_name(priv->hw);
+
ath9k_configure_leds(priv);
snprintf(priv->led_name, sizeof(priv->led_name),
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
index e8fa944..c762d84 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
@@ -38,6 +38,10 @@ static int ath9k_ps_enable;
module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave");
+int led_blink = 1;
+module_param_named(blink, led_blink, int, 0444);
+MODULE_PARM_DESC(blink, "Enable LED blink on activity");
+
#ifdef CONFIG_MAC80211_LEDS
static const struct ieee80211_tpt_blink ath9k_htc_tpt_blink[] = {
{ .throughput = 0 * 1024, .blink_time = 334 },
--
2.2.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-11 9:20 [PATCH] ath9k_htc: Add a module parameter to disable blink Hong Xu
@ 2015-01-11 9:40 ` Arend van Spriel
2015-01-11 9:50 ` Oleksij Rempel
2015-01-12 6:54 ` Bob Copeland
1 sibling, 1 reply; 10+ messages in thread
From: Arend van Spriel @ 2015-01-11 9:40 UTC (permalink / raw)
To: Hong Xu; +Cc: linux-wireless
On 01/11/15 10:20, Hong Xu wrote:
> Add an option "blink" to enable or disable the LED blink. The default
> value is set to 1 so that existing users would not experience any
> unexpected changes.
> ---
> drivers/net/wireless/ath/ath9k/htc.h | 1 +
> drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++++
> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 4 ++++
> 3 files changed, 9 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
> index 9dde265..5697097 100644
> --- a/drivers/net/wireless/ath/ath9k/htc.h
> +++ b/drivers/net/wireless/ath/ath9k/htc.h
> @@ -44,6 +44,7 @@
>
> extern struct ieee80211_ops ath9k_htc_ops;
> extern int htc_modparam_nohwcrypt;
> +extern int led_blink;
>
> enum htc_phymode {
> HTC_MODE_11NA = 0,
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
> index 50f74a2..998b558 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
> @@ -279,6 +279,10 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
> else
> priv->ah->led_pin = ATH_LED_PIN_DEF;
>
> + if (!led_blink)
> + priv->led_cdev.default_trigger =
> + ieee80211_get_radio_led_name(priv->hw);
> +
> ath9k_configure_leds(priv);
>
> snprintf(priv->led_name, sizeof(priv->led_name),
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> index e8fa944..c762d84 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> @@ -38,6 +38,10 @@ static int ath9k_ps_enable;
> module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
> MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave");
>
> +int led_blink = 1;
> +module_param_named(blink, led_blink, int, 0444);
> +MODULE_PARM_DESC(blink, "Enable LED blink on activity");
> +
Seems like this module parameter is only applicable if
CONFIG_MAC80211_LEDS is set.
Regards,
Arend
> #ifdef CONFIG_MAC80211_LEDS
> static const struct ieee80211_tpt_blink ath9k_htc_tpt_blink[] = {
> { .throughput = 0 * 1024, .blink_time = 334 },
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-11 9:40 ` Arend van Spriel
@ 2015-01-11 9:50 ` Oleksij Rempel
2015-01-11 9:59 ` Hong Xu
0 siblings, 1 reply; 10+ messages in thread
From: Oleksij Rempel @ 2015-01-11 9:50 UTC (permalink / raw)
To: Arend van Spriel, Hong Xu; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]
Am 11.01.2015 um 10:40 schrieb Arend van Spriel:
> On 01/11/15 10:20, Hong Xu wrote:
>> Add an option "blink" to enable or disable the LED blink. The default
>> value is set to 1 so that existing users would not experience any
>> unexpected changes.
>> ---
>> drivers/net/wireless/ath/ath9k/htc.h | 1 +
>> drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++++
>> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 4 ++++
>> 3 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/htc.h
>> b/drivers/net/wireless/ath/ath9k/htc.h
>> index 9dde265..5697097 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc.h
>> +++ b/drivers/net/wireless/ath/ath9k/htc.h
>> @@ -44,6 +44,7 @@
>>
>> extern struct ieee80211_ops ath9k_htc_ops;
>> extern int htc_modparam_nohwcrypt;
>> +extern int led_blink;
>>
>> enum htc_phymode {
>> HTC_MODE_11NA = 0,
>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>> b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>> index 50f74a2..998b558 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>> @@ -279,6 +279,10 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
>> else
>> priv->ah->led_pin = ATH_LED_PIN_DEF;
>>
>> + if (!led_blink)
>> + priv->led_cdev.default_trigger =
>> + ieee80211_get_radio_led_name(priv->hw);
>> +
>> ath9k_configure_leds(priv);
>>
>> snprintf(priv->led_name, sizeof(priv->led_name),
>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>> b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>> index e8fa944..c762d84 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>> @@ -38,6 +38,10 @@ static int ath9k_ps_enable;
>> module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
>> MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave");
>>
>> +int led_blink = 1;
>> +module_param_named(blink, led_blink, int, 0444);
>> +MODULE_PARM_DESC(blink, "Enable LED blink on activity");
>> +
>
> Seems like this module parameter is only applicable if
> CONFIG_MAC80211_LEDS is set.
This patch is copy&paste of ath9k version. So if some one really care,
then it can be fixed in this patch and ath9k as well.
> Regards,
> Arend
>
>> #ifdef CONFIG_MAC80211_LEDS
>> static const struct ieee80211_tpt_blink ath9k_htc_tpt_blink[] = {
>> { .throughput = 0 * 1024, .blink_time = 334 },
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-11 9:50 ` Oleksij Rempel
@ 2015-01-11 9:59 ` Hong Xu
2015-01-11 10:08 ` Oleksij Rempel
0 siblings, 1 reply; 10+ messages in thread
From: Hong Xu @ 2015-01-11 9:59 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: Arend van Spriel, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 2845 bytes --]
Oleksij Rempel <linux@rempel-privat.de> writes:
> Am 11.01.2015 um 10:40 schrieb Arend van Spriel:
>> On 01/11/15 10:20, Hong Xu wrote:
>>> Add an option "blink" to enable or disable the LED blink. The default
>>> value is set to 1 so that existing users would not experience any
>>> unexpected changes.
>>> ---
>>> drivers/net/wireless/ath/ath9k/htc.h | 1 +
>>> drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++++
>>> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 4 ++++
>>> 3 files changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/htc.h
>>> b/drivers/net/wireless/ath/ath9k/htc.h
>>> index 9dde265..5697097 100644
>>> --- a/drivers/net/wireless/ath/ath9k/htc.h
>>> +++ b/drivers/net/wireless/ath/ath9k/htc.h
>>> @@ -44,6 +44,7 @@
>>>
>>> extern struct ieee80211_ops ath9k_htc_ops;
>>> extern int htc_modparam_nohwcrypt;
>>> +extern int led_blink;
>>>
>>> enum htc_phymode {
>>> HTC_MODE_11NA = 0,
>>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>> b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>> index 50f74a2..998b558 100644
>>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>> @@ -279,6 +279,10 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
>>> else
>>> priv->ah->led_pin = ATH_LED_PIN_DEF;
>>>
>>> + if (!led_blink)
>>> + priv->led_cdev.default_trigger =
>>> + ieee80211_get_radio_led_name(priv->hw);
>>> +
>>> ath9k_configure_leds(priv);
>>>
>>> snprintf(priv->led_name, sizeof(priv->led_name),
>>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>> b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>> index e8fa944..c762d84 100644
>>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>> @@ -38,6 +38,10 @@ static int ath9k_ps_enable;
>>> module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
>>> MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave");
>>>
>>> +int led_blink = 1;
>>> +module_param_named(blink, led_blink, int, 0444);
>>> +MODULE_PARM_DESC(blink, "Enable LED blink on activity");
>>> +
>>
>> Seems like this module parameter is only applicable if
>> CONFIG_MAC80211_LEDS is set.
>
> This patch is copy&paste of ath9k version. So if some one really care,
> then it can be fixed in this patch and ath9k as well.
>
True, I also noticed parameter btcoex_enabled is also only applicable
if CONFIG_ATH9K_BTCOEX_SUPPORT is set, for both ath9k and ath9k_htc.
Best,
Hong
>> Regards,
>> Arend
>>
>>> #ifdef CONFIG_MAC80211_LEDS
>>> static const struct ieee80211_tpt_blink ath9k_htc_tpt_blink[] = {
>>> { .throughput = 0 * 1024, .blink_time = 334 },
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-11 9:59 ` Hong Xu
@ 2015-01-11 10:08 ` Oleksij Rempel
0 siblings, 0 replies; 10+ messages in thread
From: Oleksij Rempel @ 2015-01-11 10:08 UTC (permalink / raw)
To: Hong Xu; +Cc: Arend van Spriel, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 2924 bytes --]
Am 11.01.2015 um 10:59 schrieb Hong Xu:
>
> Oleksij Rempel <linux@rempel-privat.de> writes:
>
>> Am 11.01.2015 um 10:40 schrieb Arend van Spriel:
>>> On 01/11/15 10:20, Hong Xu wrote:
>>>> Add an option "blink" to enable or disable the LED blink. The default
>>>> value is set to 1 so that existing users would not experience any
>>>> unexpected changes.
>>>> ---
>>>> drivers/net/wireless/ath/ath9k/htc.h | 1 +
>>>> drivers/net/wireless/ath/ath9k/htc_drv_gpio.c | 4 ++++
>>>> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 4 ++++
>>>> 3 files changed, 9 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath9k/htc.h
>>>> b/drivers/net/wireless/ath/ath9k/htc.h
>>>> index 9dde265..5697097 100644
>>>> --- a/drivers/net/wireless/ath/ath9k/htc.h
>>>> +++ b/drivers/net/wireless/ath/ath9k/htc.h
>>>> @@ -44,6 +44,7 @@
>>>>
>>>> extern struct ieee80211_ops ath9k_htc_ops;
>>>> extern int htc_modparam_nohwcrypt;
>>>> +extern int led_blink;
>>>>
>>>> enum htc_phymode {
>>>> HTC_MODE_11NA = 0,
>>>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>>> b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>>> index 50f74a2..998b558 100644
>>>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_gpio.c
>>>> @@ -279,6 +279,10 @@ void ath9k_init_leds(struct ath9k_htc_priv *priv)
>>>> else
>>>> priv->ah->led_pin = ATH_LED_PIN_DEF;
>>>>
>>>> + if (!led_blink)
>>>> + priv->led_cdev.default_trigger =
>>>> + ieee80211_get_radio_led_name(priv->hw);
>>>> +
>>>> ath9k_configure_leds(priv);
>>>>
>>>> snprintf(priv->led_name, sizeof(priv->led_name),
>>>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>>> b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>>> index e8fa944..c762d84 100644
>>>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
>>>> @@ -38,6 +38,10 @@ static int ath9k_ps_enable;
>>>> module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
>>>> MODULE_PARM_DESC(ps_enable, "Enable WLAN PowerSave");
>>>>
>>>> +int led_blink = 1;
>>>> +module_param_named(blink, led_blink, int, 0444);
>>>> +MODULE_PARM_DESC(blink, "Enable LED blink on activity");
>>>> +
>>>
>>> Seems like this module parameter is only applicable if
>>> CONFIG_MAC80211_LEDS is set.
>>
>> This patch is copy&paste of ath9k version. So if some one really care,
>> then it can be fixed in this patch and ath9k as well.
>>
> True, I also noticed parameter btcoex_enabled is also only applicable
> if CONFIG_ATH9K_BTCOEX_SUPPORT is set, for both ath9k and ath9k_htc.
I prefer to keep ath9k_htc close to ath9k as possible, including bugs.
Process of merging this two drivers is not finished, and i didn't gave
up on it.
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-11 9:20 [PATCH] ath9k_htc: Add a module parameter to disable blink Hong Xu
2015-01-11 9:40 ` Arend van Spriel
@ 2015-01-12 6:54 ` Bob Copeland
2015-01-12 7:09 ` Hong Xu
1 sibling, 1 reply; 10+ messages in thread
From: Bob Copeland @ 2015-01-12 6:54 UTC (permalink / raw)
To: Hong Xu; +Cc: linux-wireless
On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote:
> Add an option "blink" to enable or disable the LED blink. The default
> value is set to 1 so that existing users would not experience any
> unexpected changes.
Been a while since I looked, but isn't there a way to achieve same
result by just echoing 'none' into the relevant LED's sysfs file
(something like /sys/class/leds/phy0-led/trigger)?
--
Bob Copeland %% http://bobcopeland.com/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-12 6:54 ` Bob Copeland
@ 2015-01-12 7:09 ` Hong Xu
2015-01-13 2:55 ` Julian Calaby
0 siblings, 1 reply; 10+ messages in thread
From: Hong Xu @ 2015-01-12 7:09 UTC (permalink / raw)
To: Bob Copeland; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Bob Copeland <me@bobcopeland.com> writes:
> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote:
>> Add an option "blink" to enable or disable the LED blink. The default
>> value is set to 1 so that existing users would not experience any
>> unexpected changes.
>
> Been a while since I looked, but isn't there a way to achieve same
> result by just echoing 'none' into the relevant LED's sysfs file
> (something like /sys/class/leds/phy0-led/trigger)?
It's a bit different. echo 'none' to the trigger would cause the LED
light to be dark, but if turn off the blink option here, the LED is
bright but without blinking.
Hong
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-12 7:09 ` Hong Xu
@ 2015-01-13 2:55 ` Julian Calaby
2015-01-13 5:21 ` Hong Xu
0 siblings, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2015-01-13 2:55 UTC (permalink / raw)
To: Hong Xu; +Cc: Bob Copeland, linux-wireless
Hi Hong,
On Mon, Jan 12, 2015 at 6:09 PM, Hong Xu <hong@topbug.net> wrote:
>
> Bob Copeland <me@bobcopeland.com> writes:
>
>> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote:
>>> Add an option "blink" to enable or disable the LED blink. The default
>>> value is set to 1 so that existing users would not experience any
>>> unexpected changes.
>>
>> Been a while since I looked, but isn't there a way to achieve same
>> result by just echoing 'none' into the relevant LED's sysfs file
>> (something like /sys/class/leds/phy0-led/trigger)?
>
> It's a bit different. echo 'none' to the trigger would cause the LED
> light to be dark, but if turn off the blink option here, the LED is
> bright but without blinking.
>
> Hong
I.e. it doesn't blink, it's just on when linked (isn't there a trigger
for that?) or is on solid? (echo 255 >
/sys/class/leds/phy0-led/brightness)
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ath9k_htc: Add a module parameter to disable blink
2015-01-13 2:55 ` Julian Calaby
@ 2015-01-13 5:21 ` Hong Xu
0 siblings, 0 replies; 10+ messages in thread
From: Hong Xu @ 2015-01-13 5:21 UTC (permalink / raw)
To: Julian Calaby; +Cc: Bob Copeland, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
Julian Calaby <julian.calaby@gmail.com> writes:
> Hi Hong,
>
> On Mon, Jan 12, 2015 at 6:09 PM, Hong Xu <hong@topbug.net> wrote:
>>
>> Bob Copeland <me@bobcopeland.com> writes:
>>
>>> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote:
>>>> Add an option "blink" to enable or disable the LED blink. The default
>>>> value is set to 1 so that existing users would not experience any
>>>> unexpected changes.
>>>
>>> Been a while since I looked, but isn't there a way to achieve same
>>> result by just echoing 'none' into the relevant LED's sysfs file
>>> (something like /sys/class/leds/phy0-led/trigger)?
>>
>> It's a bit different. echo 'none' to the trigger would cause the LED
>> light to be dark, but if turn off the blink option here, the LED is
>> bright but without blinking.
>>
>> Hong
>
> I.e. it doesn't blink, it's just on when linked (isn't there a trigger
> for that?) or is on solid? (echo 255 >
> /sys/class/leds/phy0-led/brightness)
It is solid on, but will be off if you turn off wifi (which echo 255 >
/.../brightness will not do). Replace ieee80211_get_radio_led_name with
ieee80211_get_assoc_led_name will use the linking trigger. I think using
linking makes more sense.
Hong
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1420967281-31175-1-git-send-email-hong@topbug.net>]
end of thread, other threads:[~2015-01-13 6:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-11 9:20 [PATCH] ath9k_htc: Add a module parameter to disable blink Hong Xu
2015-01-11 9:40 ` Arend van Spriel
2015-01-11 9:50 ` Oleksij Rempel
2015-01-11 9:59 ` Hong Xu
2015-01-11 10:08 ` Oleksij Rempel
2015-01-12 6:54 ` Bob Copeland
2015-01-12 7:09 ` Hong Xu
2015-01-13 2:55 ` Julian Calaby
2015-01-13 5:21 ` Hong Xu
[not found] <1420967281-31175-1-git-send-email-hong@topbug.net>
2015-01-11 9:17 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.