All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl.c: fix some alignment issues
Date: Sun, 11 Jan 2015 12:12:29 +0200	[thread overview]
Message-ID: <54B24C8D.1090907@redhat.com> (raw)
In-Reply-To: <54B24B12.6020703@weilnetz.de>

On 01/11/2015 12:06 PM, Stefan Weil wrote:
> Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum:
>> The main's switch had a few cases misaligned.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>>   vl.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> The misalignment was caused by tabs which were used instead of spaces.
>
> A short look on vl.c shows lots of more lines with tabs (also in other switch
> statements), so this patch could be extended to fix more lines.
This is what I saw while fixing other stuff. :)
I'll try to hunt others and send another version.

Thanks,
Marcel

>
> Stefan
>



WARNING: multiple messages have this Message-ID (diff)
From: Marcel Apfelbaum <marcel@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vl.c: fix some alignment issues
Date: Sun, 11 Jan 2015 12:12:29 +0200	[thread overview]
Message-ID: <54B24C8D.1090907@redhat.com> (raw)
In-Reply-To: <54B24B12.6020703@weilnetz.de>

On 01/11/2015 12:06 PM, Stefan Weil wrote:
> Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum:
>> The main's switch had a few cases misaligned.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>>   vl.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> The misalignment was caused by tabs which were used instead of spaces.
>
> A short look on vl.c shows lots of more lines with tabs (also in other switch
> statements), so this patch could be extended to fix more lines.
This is what I saw while fixing other stuff. :)
I'll try to hunt others and send another version.

Thanks,
Marcel

>
> Stefan
>

  reply	other threads:[~2015-01-11 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11  9:37 [Qemu-trivial] [Qemu-devel] [PATCH] vl.c: fix some alignment issues Marcel Apfelbaum
2015-01-11  9:37 ` Marcel Apfelbaum
2015-01-11 10:06 ` [Qemu-trivial] " Stefan Weil
2015-01-11 10:06   ` Stefan Weil
2015-01-11 10:12   ` Marcel Apfelbaum [this message]
2015-01-11 10:12     ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B24C8D.1090907@redhat.com \
    --to=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.