All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Hofman <pavel.hofman@ivitera.com>
To: alsa-devel <alsa-devel@alsa-project.org>, tiwai@suse.de
Subject: ESI  Juli@ crash with external clock switch - patch
Date: Sun, 11 Jan 2015 14:58:12 +0100	[thread overview]
Message-ID: <54B28174.7060008@ivitera.com> (raw)

Hi,

I have investigated a crash/kernel thread lockup when Juli@ is switched 
to external SPDIF clock and the incoming SPDIF stream changes 
samplerate. The problem appears to occur in the timed thread in charge 
of reading incoming samplerate and acting upon its change.

The problem disappears with the following patch:

diff --git a/sound/i2c/other/ak4114.c b/sound/i2c/other/ak4114.c
index c7f5633..68bb326 100644
--- a/sound/i2c/other/ak4114.c
+++ b/sound/i2c/other/ak4114.c
@@ -154,7 +154,7 @@ void snd_ak4114_reinit(struct ak4114 *chip)
  {
         chip->init = 1;
         mb();
-       flush_delayed_work(&chip->work);
+       //flush_delayed_work(&chip->work);
         ak4114_init_regs(chip);
         /* bring up statistics / event queing */
         chip->init = 0;

I am afraid I do not know enough about kernel workqueues to determine 
whether this "fix" is OK.

Interestingly, the almost identical driver ak4113.c for a very similar 
card Infrasonic Quartet (ice1724/quartet.c) does not suffer from this 
problem (tested now).

Thanks a lot for your opinion.

Best regards,

Pavel Hofman.

             reply	other threads:[~2015-01-11 13:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11 13:58 Pavel Hofman [this message]
2015-01-11 15:52 ` ESI Juli@ crash with external clock switch - patch Takashi Iwai
2015-01-11 17:57   ` Pavel Hofman
2015-01-11 20:36     ` Takashi Iwai
2015-01-11 21:00       ` Pavel Hofman
2015-01-12  8:21         ` Takashi Iwai
2015-01-12  8:34           ` Pavel Hofman
2015-01-12 15:43             ` Takashi Iwai
2015-01-15 21:15               ` Pavel Hofman
2015-01-16 17:13                 ` Takashi Iwai
2015-01-16 17:19                   ` Takashi Iwai
2015-01-16 20:36                   ` Pavel Hofman
2015-01-16 20:39                     ` Takashi Iwai
2015-01-16 20:53                       ` Pavel Hofman
2015-01-28 20:51                       ` Pavel Hofman
2015-01-28 21:21                         ` Takashi Iwai
2015-01-28 21:24                           ` Pavel Hofman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B28174.7060008@ivitera.com \
    --to=pavel.hofman@ivitera.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.