All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Hofman <pavel.hofman@ivitera.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: ESI Juli@ crash with external clock switch - patch
Date: Fri, 16 Jan 2015 21:36:10 +0100	[thread overview]
Message-ID: <54B9763A.8030405@ivitera.com> (raw)
In-Reply-To: <s5ha91isl7e.wl-tiwai@suse.de>

Dne 16.1.2015 v 18:13 Takashi Iwai napsal(a):
> OK, I'm going to send a fix series including the relevant correction.
> Give it a try later.

Thanks a lot for the patches, the external rate switching on Juli now 
works perfectly (not tested on Quartet yet). One can tell you are 
seasoned in kernel development, I would get lost in the synchronization 
and workqueue facilities.

>> I am not sure users would want/need to disable a feature which detects
>> incoming samplerate. IMO if the work thread is running only in the
>> external clock mode, nothing more is needed.
>
> Hm, but you can still see the other attributes of SPDIF input frames,
> right?  Or all these useless when the clock is set to internal?
> If so, it'd be easy to add the dynamic turn on/off per the clock
> mode.

You are right, that would disable update of other controls informing 
about incoming SPDIF details. These are useful in internal clock mode 
too - if the soundcard is master for the spdif chain. A new control 
would make sense then.

I am leaving for a week, then I will test quartet and the PM features.

Again, thanks a lot for the patches.


Pavel.

  parent reply	other threads:[~2015-01-16 20:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11 13:58 ESI Juli@ crash with external clock switch - patch Pavel Hofman
2015-01-11 15:52 ` Takashi Iwai
2015-01-11 17:57   ` Pavel Hofman
2015-01-11 20:36     ` Takashi Iwai
2015-01-11 21:00       ` Pavel Hofman
2015-01-12  8:21         ` Takashi Iwai
2015-01-12  8:34           ` Pavel Hofman
2015-01-12 15:43             ` Takashi Iwai
2015-01-15 21:15               ` Pavel Hofman
2015-01-16 17:13                 ` Takashi Iwai
2015-01-16 17:19                   ` Takashi Iwai
2015-01-16 20:36                   ` Pavel Hofman [this message]
2015-01-16 20:39                     ` Takashi Iwai
2015-01-16 20:53                       ` Pavel Hofman
2015-01-28 20:51                       ` Pavel Hofman
2015-01-28 21:21                         ` Takashi Iwai
2015-01-28 21:24                           ` Pavel Hofman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B9763A.8030405@ivitera.com \
    --to=pavel.hofman@ivitera.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.