* [PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function
@ 2015-01-11 18:12 Rickard Strandqvist
2015-01-11 21:00 ` Samuel Pitoiset
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 18:12 UTC (permalink / raw)
To: David Airlie, Ben Skeggs
Cc: Rickard Strandqvist, Samuel Pitoiset, dri-devel, linux-kernel
Remove the function nouveau_perfsig_wrap() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/gpu/drm/nouveau/core/engine/perfmon/base.c | 20 --------------------
drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h | 5 -----
2 files changed, 25 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
index 6301381..d0c5255 100644
--- a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
+++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
@@ -80,26 +80,6 @@ nouveau_perfsig_find(struct nouveau_perfmon *ppm, const char *name, u32 size,
return nouveau_perfsig_find_(dom, name, size);
}
-struct nouveau_perfctr *
-nouveau_perfsig_wrap(struct nouveau_perfmon *ppm, const char *name,
- struct nouveau_perfdom **pdom)
-{
- struct nouveau_perfsig *sig;
- struct nouveau_perfctr *ctr;
-
- sig = nouveau_perfsig_find(ppm, name, strlen(name), pdom);
- if (!sig)
- return NULL;
-
- ctr = kzalloc(sizeof(*ctr), GFP_KERNEL);
- if (ctr) {
- ctr->signal[0] = sig;
- ctr->logic_op = 0xaaaa;
- }
-
- return ctr;
-}
-
/*******************************************************************************
* Perfmon object classes
******************************************************************************/
diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
index 0ac8714..1a0989e 100644
--- a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
+++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
@@ -30,11 +30,6 @@ struct nouveau_perfsig {
const char *name;
};
-struct nouveau_perfdom;
-struct nouveau_perfctr *
-nouveau_perfsig_wrap(struct nouveau_perfmon *, const char *,
- struct nouveau_perfdom **);
-
struct nouveau_specdom {
u16 signal_nr;
const struct nouveau_specsig *signal;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function
2015-01-11 18:12 [PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function Rickard Strandqvist
@ 2015-01-11 21:00 ` Samuel Pitoiset
2015-01-11 22:05 ` Rickard Strandqvist
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Pitoiset @ 2015-01-11 21:00 UTC (permalink / raw)
To: Rickard Strandqvist, David Airlie, Ben Skeggs; +Cc: dri-devel, linux-kernel
Hi Rickard,
Thanks for submitting this patch, but I already submitted the same a few
weeks ago. :-)
This function will be removed when I will submit my work on this area.
Greetings,
Samuel Pitoiset.
On 01/11/2015 07:12 PM, Rickard Strandqvist wrote:
> Remove the function nouveau_perfsig_wrap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/gpu/drm/nouveau/core/engine/perfmon/base.c | 20 --------------------
> drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h | 5 -----
> 2 files changed, 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> index 6301381..d0c5255 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
> @@ -80,26 +80,6 @@ nouveau_perfsig_find(struct nouveau_perfmon *ppm, const char *name, u32 size,
> return nouveau_perfsig_find_(dom, name, size);
> }
>
> -struct nouveau_perfctr *
> -nouveau_perfsig_wrap(struct nouveau_perfmon *ppm, const char *name,
> - struct nouveau_perfdom **pdom)
> -{
> - struct nouveau_perfsig *sig;
> - struct nouveau_perfctr *ctr;
> -
> - sig = nouveau_perfsig_find(ppm, name, strlen(name), pdom);
> - if (!sig)
> - return NULL;
> -
> - ctr = kzalloc(sizeof(*ctr), GFP_KERNEL);
> - if (ctr) {
> - ctr->signal[0] = sig;
> - ctr->logic_op = 0xaaaa;
> - }
> -
> - return ctr;
> -}
> -
> /*******************************************************************************
> * Perfmon object classes
> ******************************************************************************/
> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> index 0ac8714..1a0989e 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
> @@ -30,11 +30,6 @@ struct nouveau_perfsig {
> const char *name;
> };
>
> -struct nouveau_perfdom;
> -struct nouveau_perfctr *
> -nouveau_perfsig_wrap(struct nouveau_perfmon *, const char *,
> - struct nouveau_perfdom **);
> -
> struct nouveau_specdom {
> u16 signal_nr;
> const struct nouveau_specsig *signal;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function
2015-01-11 21:00 ` Samuel Pitoiset
@ 2015-01-11 22:05 ` Rickard Strandqvist
0 siblings, 0 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 22:05 UTC (permalink / raw)
To: Samuel Pitoiset
Cc: David Airlie, Ben Skeggs, dri-devel, Linux Kernel Mailing List
2015-01-11 22:00 GMT+01:00 Samuel Pitoiset <samuel.pitoiset@gmail.com>:
> Hi Rickard,
>
> Thanks for submitting this patch, but I already submitted the same a few
> weeks ago. :-)
>
> This function will be removed when I will submit my work on this area.
>
> Greetings,
> Samuel Pitoiset.
>
>
> On 01/11/2015 07:12 PM, Rickard Strandqvist wrote:
>>
>> Remove the function nouveau_perfsig_wrap() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called
>> cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>> drivers/gpu/drm/nouveau/core/engine/perfmon/base.c | 20
>> --------------------
>> drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h | 5 -----
>> 2 files changed, 25 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
>> b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
>> index 6301381..d0c5255 100644
>> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
>> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/base.c
>> @@ -80,26 +80,6 @@ nouveau_perfsig_find(struct nouveau_perfmon *ppm, const
>> char *name, u32 size,
>> return nouveau_perfsig_find_(dom, name, size);
>> }
>> -struct nouveau_perfctr *
>> -nouveau_perfsig_wrap(struct nouveau_perfmon *ppm, const char *name,
>> - struct nouveau_perfdom **pdom)
>> -{
>> - struct nouveau_perfsig *sig;
>> - struct nouveau_perfctr *ctr;
>> -
>> - sig = nouveau_perfsig_find(ppm, name, strlen(name), pdom);
>> - if (!sig)
>> - return NULL;
>> -
>> - ctr = kzalloc(sizeof(*ctr), GFP_KERNEL);
>> - if (ctr) {
>> - ctr->signal[0] = sig;
>> - ctr->logic_op = 0xaaaa;
>> - }
>> -
>> - return ctr;
>> -}
>> -
>>
>> /*******************************************************************************
>> * Perfmon object classes
>>
>> ******************************************************************************/
>> diff --git a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
>> b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
>> index 0ac8714..1a0989e 100644
>> --- a/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
>> +++ b/drivers/gpu/drm/nouveau/core/engine/perfmon/priv.h
>> @@ -30,11 +30,6 @@ struct nouveau_perfsig {
>> const char *name;
>> };
>> -struct nouveau_perfdom;
>> -struct nouveau_perfctr *
>> -nouveau_perfsig_wrap(struct nouveau_perfmon *, const char *,
>> - struct nouveau_perfdom **);
>> -
>> struct nouveau_specdom {
>> u16 signal_nr;
>> const struct nouveau_specsig *signal;
>
>
Hi Samuel
Thanks, another of the drawbacks that I start this off too long ago :(
Kind regards
Rickard Strandqvist
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-11 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-11 18:12 [PATCH] drm: nouveau: core: engine: perfmon: base: Remove unused function Rickard Strandqvist
2015-01-11 21:00 ` Samuel Pitoiset
2015-01-11 22:05 ` Rickard Strandqvist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.