From: Zhou Wang <wangzhou1@hisilicon.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, liguozhu@hisilicon.com,
xuwei5@hisilicon.com, linux-mtd@lists.infradead.org,
haojian.zhuang@gmail.com, caizhiyong@huawei.com,
yubingxu@hisilicon.com,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc
Date: Mon, 12 Jan 2015 17:18:38 +0800 [thread overview]
Message-ID: <54B3916E.4040906@hisilicon.com> (raw)
In-Reply-To: <5265608.Ut8IQVYZc5@wuerfel>
On 2015/1/12 16:21, Arnd Bergmann wrote:
> On Monday 12 January 2015 15:28:53 Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> ---
>
> I haven't looked at earlier versions, but it looks very good to
> me overall. Just add a patch description above please.
Hi Arnd,
The earlier version is same with this one, just change E-mail
address here. Will add a patch description in next version. Thanks!
>
> One tiny detail:
>
>> +static const struct of_device_id nfc_id_table[] = {
>> + { .compatible = "hisilicon,504-nfc" },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(of, nfc_id_table);
>> +
>> +static struct platform_driver hisi_nfc_driver = {
>> + .driver = {
>> + .name = "hisi_nand",
>> + .of_match_table = of_match_ptr(nfc_id_table),
>> + .pm = &hisi_nfc_pm_ops,
>> + },
>> + .probe = hisi_nfc_probe,
>> + .remove = hisi_nfc_remove,
>> +};
>
> Remove the of_match_ptr() macro here to avoid a warning when
> CONFIG_OF is not set.
Will remove the macro here, thanks!
Best regards,
Zhou Wang
>
> Arnd
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: wangzhou1@hisilicon.com (Zhou Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc
Date: Mon, 12 Jan 2015 17:18:38 +0800 [thread overview]
Message-ID: <54B3916E.4040906@hisilicon.com> (raw)
In-Reply-To: <5265608.Ut8IQVYZc5@wuerfel>
On 2015/1/12 16:21, Arnd Bergmann wrote:
> On Monday 12 January 2015 15:28:53 Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> ---
>
> I haven't looked at earlier versions, but it looks very good to
> me overall. Just add a patch description above please.
Hi Arnd,
The earlier version is same with this one, just change E-mail
address here. Will add a patch description in next version. Thanks!
>
> One tiny detail:
>
>> +static const struct of_device_id nfc_id_table[] = {
>> + { .compatible = "hisilicon,504-nfc" },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(of, nfc_id_table);
>> +
>> +static struct platform_driver hisi_nfc_driver = {
>> + .driver = {
>> + .name = "hisi_nand",
>> + .of_match_table = of_match_ptr(nfc_id_table),
>> + .pm = &hisi_nfc_pm_ops,
>> + },
>> + .probe = hisi_nfc_probe,
>> + .remove = hisi_nfc_remove,
>> +};
>
> Remove the of_match_ptr() macro here to avoid a warning when
> CONFIG_OF is not set.
Will remove the macro here, thanks!
Best regards,
Zhou Wang
>
> Arnd
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Wang <wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
caizhiyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
yubingxu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Subject: Re: [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc
Date: Mon, 12 Jan 2015 17:18:38 +0800 [thread overview]
Message-ID: <54B3916E.4040906@hisilicon.com> (raw)
In-Reply-To: <5265608.Ut8IQVYZc5@wuerfel>
On 2015/1/12 16:21, Arnd Bergmann wrote:
> On Monday 12 January 2015 15:28:53 Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
>> ---
>
> I haven't looked at earlier versions, but it looks very good to
> me overall. Just add a patch description above please.
Hi Arnd,
The earlier version is same with this one, just change E-mail
address here. Will add a patch description in next version. Thanks!
>
> One tiny detail:
>
>> +static const struct of_device_id nfc_id_table[] = {
>> + { .compatible = "hisilicon,504-nfc" },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(of, nfc_id_table);
>> +
>> +static struct platform_driver hisi_nfc_driver = {
>> + .driver = {
>> + .name = "hisi_nand",
>> + .of_match_table = of_match_ptr(nfc_id_table),
>> + .pm = &hisi_nfc_pm_ops,
>> + },
>> + .probe = hisi_nfc_probe,
>> + .remove = hisi_nfc_remove,
>> +};
>
> Remove the of_match_ptr() macro here to avoid a warning when
> CONFIG_OF is not set.
Will remove the macro here, thanks!
Best regards,
Zhou Wang
>
> Arnd
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-12 9:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 7:28 [PATCH v6 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Zhou Wang
2015-01-12 7:28 ` Zhou Wang
2015-01-12 7:28 ` Zhou Wang
2015-01-12 7:28 ` [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for " Zhou Wang
2015-01-12 7:28 ` Zhou Wang
2015-01-12 7:28 ` Zhou Wang
2015-01-12 8:21 ` Arnd Bergmann
2015-01-12 8:21 ` Arnd Bergmann
2015-01-12 8:21 ` Arnd Bergmann
2015-01-12 9:18 ` Zhou Wang [this message]
2015-01-12 9:18 ` Zhou Wang
2015-01-12 9:18 ` Zhou Wang
2015-01-13 3:58 ` Brian Norris
2015-01-13 3:58 ` Brian Norris
2015-01-13 3:58 ` Brian Norris
2015-01-14 12:34 ` Zhou Wang
2015-01-14 12:34 ` Zhou Wang
2015-01-14 12:34 ` Zhou Wang
2015-01-14 19:25 ` Brian Norris
2015-01-14 19:25 ` Brian Norris
2015-01-14 19:25 ` Brian Norris
2015-01-15 1:27 ` Zhou Wang
2015-01-15 1:27 ` Zhou Wang
2015-01-15 1:27 ` Zhou Wang
2015-01-13 4:02 ` Brian Norris
2015-01-13 4:02 ` Brian Norris
2015-01-13 4:02 ` Brian Norris
2015-01-14 12:45 ` Zhou Wang
2015-01-14 12:45 ` Zhou Wang
2015-01-14 12:45 ` Zhou Wang
2015-01-12 7:28 ` [PATCH v6 2/2] mtd: hisilicon: add device tree binding documentation Zhou Wang
2015-01-12 7:28 ` Zhou Wang
2015-01-12 7:28 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3916E.4040906@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=arnd@arndb.de \
--cc=caizhiyong@huawei.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xuwei5@hisilicon.com \
--cc=yubingxu@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.