From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>, tony@atomide.com
Cc: nm@ti.com, balbi@ti.com, george.cherian@ti.com, nsekhar@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] phy: ti-pipe3: Fix SATA across suspend/resume
Date: Mon, 12 Jan 2015 11:23:51 +0200 [thread overview]
Message-ID: <54B392A7.2080702@ti.com> (raw)
In-Reply-To: <54AFDEB9.3060402@ti.com>
On 09/01/15 15:59, Kishon Vijay Abraham I wrote:
> Hi Roger,
>
> On Thursday 08 January 2015 04:47 PM, Roger Quadros wrote:
>> Failed test case: Boot without SATA drive connected. Suspend/resume
>> the board and then connect SATA drive. It fails to enumerate.
>>
>> Due to Errata i783 "SATA Lockup After SATA DPLL Unlock/Relock"
>> we can't allow SATA DPLL to be in the unlocked state.
>> The SATA refclk (sata_ref_clk) is the source of the SATA_DPLL.
>> Till now this clock was controlled by the AHCI SATA driver and was being
>> shut off during system suspend (if the SATA drive was not already attached)
>> causing the SATA DPLL to be unlocked and so causing errata i783.
>>
>> To prevent sata_ref_clk from being disabled, we move the control of
>> this clock from the SATA AHCI driver to the SATA PHY driver and prevent
>> it from being disabled.
>>
>> This also fixes the issue of SATA not working on OMAP5/DRA7 when
>> AHCI platform driver is built as a module.
>
> I feel the dt patches and the PHY patches can go separately. Can you split and
> re-send?
OK. will re-send.
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>, <tony@atomide.com>
Cc: <nm@ti.com>, <balbi@ti.com>, <george.cherian@ti.com>,
<nsekhar@ti.com>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] phy: ti-pipe3: Fix SATA across suspend/resume
Date: Mon, 12 Jan 2015 11:23:51 +0200 [thread overview]
Message-ID: <54B392A7.2080702@ti.com> (raw)
In-Reply-To: <54AFDEB9.3060402@ti.com>
On 09/01/15 15:59, Kishon Vijay Abraham I wrote:
> Hi Roger,
>
> On Thursday 08 January 2015 04:47 PM, Roger Quadros wrote:
>> Failed test case: Boot without SATA drive connected. Suspend/resume
>> the board and then connect SATA drive. It fails to enumerate.
>>
>> Due to Errata i783 "SATA Lockup After SATA DPLL Unlock/Relock"
>> we can't allow SATA DPLL to be in the unlocked state.
>> The SATA refclk (sata_ref_clk) is the source of the SATA_DPLL.
>> Till now this clock was controlled by the AHCI SATA driver and was being
>> shut off during system suspend (if the SATA drive was not already attached)
>> causing the SATA DPLL to be unlocked and so causing errata i783.
>>
>> To prevent sata_ref_clk from being disabled, we move the control of
>> this clock from the SATA AHCI driver to the SATA PHY driver and prevent
>> it from being disabled.
>>
>> This also fixes the issue of SATA not working on OMAP5/DRA7 when
>> AHCI platform driver is built as a module.
>
> I feel the dt patches and the PHY patches can go separately. Can you split and
> re-send?
OK. will re-send.
cheers,
-roger
next prev parent reply other threads:[~2015-01-12 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 12:05 [PATCH 0/2] phy: ti-pipe3: fixes for 3.19-rc Roger Quadros
2014-12-19 12:05 ` Roger Quadros
2014-12-19 12:05 ` [PATCH 1/2] phy: ti-pipe3: Disable clocks on system suspend Roger Quadros
2014-12-19 12:05 ` Roger Quadros
2015-01-09 13:57 ` Kishon Vijay Abraham I
2015-01-09 13:57 ` Kishon Vijay Abraham I
2015-01-12 9:21 ` Roger Quadros
2015-01-12 9:21 ` Roger Quadros
2014-12-19 12:05 ` [PATCH 2/2] phy: ti-pipe3: Fix SATA across suspend/resume Roger Quadros
2014-12-19 12:05 ` Roger Quadros
2014-12-22 13:52 ` Kishon Vijay Abraham I
2014-12-22 13:52 ` Kishon Vijay Abraham I
[not found] ` <5498221C.6010701-l0cyMroinI0@public.gmane.org>
2014-12-29 9:53 ` Roger Quadros
2014-12-29 9:53 ` Roger Quadros
2015-01-08 11:17 ` [PATCH v2 " Roger Quadros
2015-01-08 11:17 ` Roger Quadros
2015-01-09 13:59 ` Kishon Vijay Abraham I
2015-01-09 13:59 ` Kishon Vijay Abraham I
2015-01-12 9:23 ` Roger Quadros [this message]
2015-01-12 9:23 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B392A7.2080702@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.