All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: "Vincent Génieux" <vincent2014@startigen.fr>, yocto@yoctoproject.org
Subject: Re: [OE-core] fix '[[: not found' error message using dash
Date: Mon, 12 Jan 2015 09:11:59 -0500	[thread overview]
Message-ID: <54B3D62F.4020901@windriver.com> (raw)
In-Reply-To: <1421070137-22024-1-git-send-email-vincent2014@startigen.fr>

Not bad for a first patch submission! Just two little things to change.

#1, this should go to the oe-core mailing list 
(openembedded-core@lists.openembedded.org),
and not the yocto one. It definitely is not always obvious at the
beginning which list to use for what!

On 15-01-12 08:42 AM, Vincent Génieux wrote:
> This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112

You can replace the bug reference with:

[YOCTO: #7112]

Bruce

> bash specific syntax '[[ test ]]' replaced with '[ test ]'.
>
> Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>
> ---
>   meta/classes/kernel.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 70ed95b..2a6ec34 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -403,7 +403,7 @@ do_strip() {
>   			  gawk '{print $1}'`
>
>   		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
> -			if [[ "$headers" != *"$str"* ]]; then
> +			if [ "$headers" != *"$str"* ]; then
>   				bbwarn "Section not found: $str";
>   			fi
>
>



      reply	other threads:[~2015-01-12 14:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 13:42 [OE-core] fix '[[: not found' error message using dash Vincent Génieux
2015-01-12 14:11 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B3D62F.4020901@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=vincent2014@startigen.fr \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.