All of lore.kernel.org
 help / color / mirror / Atom feed
* [OE-core] fix '[[: not found' error message using dash
@ 2015-01-12 13:42 Vincent Génieux
  2015-01-12 14:11 ` Bruce Ashfield
  0 siblings, 1 reply; 2+ messages in thread
From: Vincent Génieux @ 2015-01-12 13:42 UTC (permalink / raw)
  To: yocto

This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112
bash specific syntax '[[ test ]]' replaced with '[ test ]'.

Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 70ed95b..2a6ec34 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -403,7 +403,7 @@ do_strip() {
 			  gawk '{print $1}'`
 
 		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
-			if [[ "$headers" != *"$str"* ]]; then
+			if [ "$headers" != *"$str"* ]; then
 				bbwarn "Section not found: $str";
 			fi
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core] fix '[[: not found' error message using dash
  2015-01-12 13:42 [OE-core] fix '[[: not found' error message using dash Vincent Génieux
@ 2015-01-12 14:11 ` Bruce Ashfield
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2015-01-12 14:11 UTC (permalink / raw)
  To: Vincent Génieux, yocto

Not bad for a first patch submission! Just two little things to change.

#1, this should go to the oe-core mailing list 
(openembedded-core@lists.openembedded.org),
and not the yocto one. It definitely is not always obvious at the
beginning which list to use for what!

On 15-01-12 08:42 AM, Vincent Génieux wrote:
> This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112

You can replace the bug reference with:

[YOCTO: #7112]

Bruce

> bash specific syntax '[[ test ]]' replaced with '[ test ]'.
>
> Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>
> ---
>   meta/classes/kernel.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 70ed95b..2a6ec34 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -403,7 +403,7 @@ do_strip() {
>   			  gawk '{print $1}'`
>
>   		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
> -			if [[ "$headers" != *"$str"* ]]; then
> +			if [ "$headers" != *"$str"* ]; then
>   				bbwarn "Section not found: $str";
>   			fi
>
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-12 14:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 13:42 [OE-core] fix '[[: not found' error message using dash Vincent Génieux
2015-01-12 14:11 ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.