All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7791: add MLB+ clock
Date: Mon, 12 Jan 2015 20:40:21 +0000	[thread overview]
Message-ID: <54B43135.6000002@cogentembedded.com> (raw)
In-Reply-To: <7846462.yepFC759KH@wasted.cogentembedded.com>

Hello.

On 12/18/2014 11:43 PM, Sergei Shtylyov wrote:

> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>

> Add MLB+ clock to R8A7791 device tree.

> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> [Sergei: rebased, renamed, added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
> This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> 'renesas.git' repo.

>   arch/arm/boot/dts/r8a7791.dtsi            |   10 +++++-----
>   include/dt-bindings/clock/r8a7791-clock.h |    1 +
>   2 files changed, 6 insertions(+), 5 deletions(-)

> Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
> =================================> --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1154,17 +1154,17 @@
>   		mstp8_clks: mstp8_clks@e6150990 {
>   			compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
>   			reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> -			clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> -				 <&zs_clk>, <&zs_clk>;
> +			clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,

    Oops, the first two clocks need to be swapped. I'll send a fix (since this 
patch has been merged already).

> +			         <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
>   			#clock-cells = <1>;
>   			clock-indices = <
> -				R8A7791_CLK_IPMMU_SGX
> +				R8A7791_CLK_IPMMU_SGX R8A7791_CLK_MLB
>   				R8A7791_CLK_VIN2 R8A7791_CLK_VIN1 R8A7791_CLK_VIN0
>   				R8A7791_CLK_ETHER R8A7791_CLK_SATA1 R8A7791_CLK_SATA0
>   			>;
[...]

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7791: add MLB+ clock
Date: Mon, 12 Jan 2015 23:40:21 +0300	[thread overview]
Message-ID: <54B43135.6000002@cogentembedded.com> (raw)
In-Reply-To: <7846462.yepFC759KH@wasted.cogentembedded.com>

Hello.

On 12/18/2014 11:43 PM, Sergei Shtylyov wrote:

> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>

> Add MLB+ clock to R8A7791 device tree.

> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> [Sergei: rebased, renamed, added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
> This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> 'renesas.git' repo.

>   arch/arm/boot/dts/r8a7791.dtsi            |   10 +++++-----
>   include/dt-bindings/clock/r8a7791-clock.h |    1 +
>   2 files changed, 6 insertions(+), 5 deletions(-)

> Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1154,17 +1154,17 @@
>   		mstp8_clks: mstp8_clks at e6150990 {
>   			compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
>   			reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> -			clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> -				 <&zs_clk>, <&zs_clk>;
> +			clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,

    Oops, the first two clocks need to be swapped. I'll send a fix (since this 
patch has been merged already).

> +			         <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
>   			#clock-cells = <1>;
>   			clock-indices = <
> -				R8A7791_CLK_IPMMU_SGX
> +				R8A7791_CLK_IPMMU_SGX R8A7791_CLK_MLB
>   				R8A7791_CLK_VIN2 R8A7791_CLK_VIN1 R8A7791_CLK_VIN0
>   				R8A7791_CLK_ETHER R8A7791_CLK_SATA1 R8A7791_CLK_SATA0
>   			>;
[...]

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: horms@verge.net.au, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org
Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7791: add MLB+ clock
Date: Mon, 12 Jan 2015 23:40:21 +0300	[thread overview]
Message-ID: <54B43135.6000002@cogentembedded.com> (raw)
In-Reply-To: <7846462.yepFC759KH@wasted.cogentembedded.com>

Hello.

On 12/18/2014 11:43 PM, Sergei Shtylyov wrote:

> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>

> Add MLB+ clock to R8A7791 device tree.

> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> [Sergei: rebased, renamed, added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
> This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> 'renesas.git' repo.

>   arch/arm/boot/dts/r8a7791.dtsi            |   10 +++++-----
>   include/dt-bindings/clock/r8a7791-clock.h |    1 +
>   2 files changed, 6 insertions(+), 5 deletions(-)

> Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1154,17 +1154,17 @@
>   		mstp8_clks: mstp8_clks@e6150990 {
>   			compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
>   			reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> -			clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> -				 <&zs_clk>, <&zs_clk>;
> +			clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,

    Oops, the first two clocks need to be swapped. I'll send a fix (since this 
patch has been merged already).

> +			         <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
>   			#clock-cells = <1>;
>   			clock-indices = <
> -				R8A7791_CLK_IPMMU_SGX
> +				R8A7791_CLK_IPMMU_SGX R8A7791_CLK_MLB
>   				R8A7791_CLK_VIN2 R8A7791_CLK_VIN1 R8A7791_CLK_VIN0
>   				R8A7791_CLK_ETHER R8A7791_CLK_SATA1 R8A7791_CLK_SATA0
>   			>;
[...]

WBR, Sergei


  parent reply	other threads:[~2015-01-12 20:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 20:43 [PATCH] ARM: shmobile: r8a7791: add MLB+ clock Sergei Shtylyov
2014-12-18 20:43 ` Sergei Shtylyov
2014-12-18 20:43 ` Sergei Shtylyov
2014-12-22  0:06 ` Simon Horman
2014-12-22  0:06   ` Simon Horman
2014-12-22  0:06   ` Simon Horman
2015-01-12 20:40 ` Sergei Shtylyov [this message]
2015-01-12 20:40   ` Sergei Shtylyov
2015-01-12 20:40   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B43135.6000002@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.