All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Li, ZhenHua" <zhen-hual@hp.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: alex.williamson@redhat.com, indou.takao@jp.fujitsu.com,
	bhe@redhat.com, tom.vaden@hp.com, rwright@hp.com,
	dwmw2@infradead.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, lisa.mitchell@hp.com,
	jerry.hoemann@hp.com, iommu@lists.linux-foundation.org, "Li,
	ZhenHua" <zhen-hual@hp.com>,
	ddutile@redhat.com, doug.hatch@hp.com,
	ishii.hironobu@jp.fujitsu.com, linux-pci@vger.kernel.org,
	bhelgaas@google.com, billsumnerlinux@gmail.com, li.zhang6@hp.com,
	dyoung@redhat.com, vgoyal@redhat.com
Subject: Re: [PATCH v8 01/10] iommu/vt-d: Update iommu_attach_domain() and its callers
Date: Tue, 13 Jan 2015 09:28:53 +0800	[thread overview]
Message-ID: <54B474D5.8090500@hp.com> (raw)
In-Reply-To: <20150112151855.GB6343@8bytes.org>

On 01/12/2015 11:18 PM, Joerg Roedel wrote:
> On Mon, Jan 12, 2015 at 03:06:19PM +0800, Li, Zhen-Hua wrote:
>> Allow specification of the domain-id for the new domain.
>> This patch only adds the 'did' parameter to iommu_attach_domain()
>> and modifies all of its callers to specify the default value of -1
>> which says "no did specified, allocate a new one".
>
> I think its better to keep the old iommu_attach_domain() interface in
> place and introduce a new function (like iommu_attach_domain_with_id()
> or something) which has the additional parameter. Then you can rewrite
> iommu_attach_domain():
>
> 	iommu_attach_domai(...)
> 	{
> 		return iommu_attach_domain_with_id(..., -1);
> 	}
>
> This way you don't have to update all the callers of
> iommu_attach_domain() and the interface is more readable.
>
>
> 	Joerg
>

That's a good way. I will do this in next version.

Thanks
Zhenhua



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "Li, ZhenHua" <zhen-hual-VXdhtT5mjnY@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	tom.vaden-VXdhtT5mjnY@public.gmane.org,
	rwright-VXdhtT5mjnY@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lisa.mitchell-VXdhtT5mjnY@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"Li, ZhenHua" <zhen-hual-VXdhtT5mjnY@public.gmane.org>,
	doug.hatch-VXdhtT5mjnY@public.gmane.org,
	ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	li.zhang6-VXdhtT5mjnY@public.gmane.org,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v8 01/10] iommu/vt-d: Update iommu_attach_domain() and its callers
Date: Tue, 13 Jan 2015 09:28:53 +0800	[thread overview]
Message-ID: <54B474D5.8090500@hp.com> (raw)
In-Reply-To: <20150112151855.GB6343-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

On 01/12/2015 11:18 PM, Joerg Roedel wrote:
> On Mon, Jan 12, 2015 at 03:06:19PM +0800, Li, Zhen-Hua wrote:
>> Allow specification of the domain-id for the new domain.
>> This patch only adds the 'did' parameter to iommu_attach_domain()
>> and modifies all of its callers to specify the default value of -1
>> which says "no did specified, allocate a new one".
>
> I think its better to keep the old iommu_attach_domain() interface in
> place and introduce a new function (like iommu_attach_domain_with_id()
> or something) which has the additional parameter. Then you can rewrite
> iommu_attach_domain():
>
> 	iommu_attach_domai(...)
> 	{
> 		return iommu_attach_domain_with_id(..., -1);
> 	}
>
> This way you don't have to update all the callers of
> iommu_attach_domain() and the interface is more readable.
>
>
> 	Joerg
>

That's a good way. I will do this in next version.

Thanks
Zhenhua

WARNING: multiple messages have this Message-ID (diff)
From: "Li, ZhenHua" <zhen-hual@hp.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: dwmw2@infradead.org, indou.takao@jp.fujitsu.com, bhe@redhat.com,
	vgoyal@redhat.com, dyoung@redhat.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, kexec@lists.infradead.org,
	alex.williamson@redhat.com, ddutile@redhat.com,
	ishii.hironobu@jp.fujitsu.com, bhelgaas@google.com,
	doug.hatch@hp.com, jerry.hoemann@hp.com, tom.vaden@hp.com,
	li.zhang6@hp.com, lisa.mitchell@hp.com,
	billsumnerlinux@gmail.com, rwright@hp.com, "Li,
	ZhenHua" <zhen-hual@hp.com>
Subject: Re: [PATCH v8 01/10] iommu/vt-d: Update iommu_attach_domain() and its callers
Date: Tue, 13 Jan 2015 09:28:53 +0800	[thread overview]
Message-ID: <54B474D5.8090500@hp.com> (raw)
In-Reply-To: <20150112151855.GB6343@8bytes.org>

On 01/12/2015 11:18 PM, Joerg Roedel wrote:
> On Mon, Jan 12, 2015 at 03:06:19PM +0800, Li, Zhen-Hua wrote:
>> Allow specification of the domain-id for the new domain.
>> This patch only adds the 'did' parameter to iommu_attach_domain()
>> and modifies all of its callers to specify the default value of -1
>> which says "no did specified, allocate a new one".
>
> I think its better to keep the old iommu_attach_domain() interface in
> place and introduce a new function (like iommu_attach_domain_with_id()
> or something) which has the additional parameter. Then you can rewrite
> iommu_attach_domain():
>
> 	iommu_attach_domai(...)
> 	{
> 		return iommu_attach_domain_with_id(..., -1);
> 	}
>
> This way you don't have to update all the callers of
> iommu_attach_domain() and the interface is more readable.
>
>
> 	Joerg
>

That's a good way. I will do this in next version.

Thanks
Zhenhua



  reply	other threads:[~2015-01-13  1:30 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  7:06 [PATCH v8 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel Li, Zhen-Hua
2015-01-12  7:06 ` Li, Zhen-Hua
2015-01-12  7:06 ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 01/10] iommu/vt-d: Update iommu_attach_domain() and its callers Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12 15:18   ` Joerg Roedel
2015-01-12 15:18     ` Joerg Roedel
2015-01-12 15:18     ` Joerg Roedel
2015-01-13  1:28     ` Li, ZhenHua [this message]
2015-01-13  1:28       ` Li, ZhenHua
2015-01-13  1:28       ` Li, ZhenHua
2015-01-12  7:06 ` [PATCH v8 02/10] iommu/vt-d: Items required for kdump Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12 15:22   ` Joerg Roedel
2015-01-12 15:22     ` Joerg Roedel
2015-01-12 15:29     ` Vivek Goyal
2015-01-12 15:29       ` Vivek Goyal
2015-01-12 15:29       ` Vivek Goyal
2015-01-12 16:06       ` Joerg Roedel
2015-01-12 16:06         ` Joerg Roedel
2015-01-12 16:06         ` Joerg Roedel
2015-01-12 16:15         ` Vivek Goyal
2015-01-12 16:15           ` Vivek Goyal
2015-01-12 16:15           ` Vivek Goyal
2015-01-12 16:48           ` Joerg Roedel
2015-01-12 16:48             ` Joerg Roedel
2015-01-12 16:48             ` Joerg Roedel
2015-01-13 11:41       ` Baoquan He
2015-01-13 11:41         ` Baoquan He
2015-01-13  8:12     ` Li, ZhenHua
2015-01-13  8:12       ` Li, ZhenHua
     [not found]       ` <54B4D36D.8030204-VXdhtT5mjnY@public.gmane.org>
2015-01-13 11:52         ` Joerg Roedel
2015-01-13 11:52           ` Joerg Roedel
2015-01-12  7:06 ` [PATCH v8 03/10] iommu/vt-d: Add domain-id functions Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 04/10] iommu/vt-d: functions to copy data from old mem Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 05/10] iommu/vt-d: Add functions to load and save old re Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-15  3:28   ` Baoquan He
2015-01-15  3:28     ` Baoquan He
2015-01-15  3:28     ` Baoquan He
2015-01-15  5:45     ` Li, ZhenHua
2015-01-15  5:45       ` Li, ZhenHua
2015-01-15  7:01       ` Baoquan He
2015-01-15  7:01         ` Baoquan He
2015-01-15  7:01         ` Baoquan He
2015-01-12  7:06 ` [PATCH v8 07/10] iommu/vt-d: enable kdump support in iommu module Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 08/10] iommu/vt-d: assign new page table for dma_map Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 09/10] iommu/vt-d: Copy functions for irte Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06 ` [PATCH v8 10/10] iommu/vt-d: Use old irte in kdump kernel Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  7:06   ` Li, Zhen-Hua
2015-01-12  8:00 ` [PATCH v8 0/10] iommu/vt-d: Fix intel vt-d faults " Li, ZhenHua
2015-01-12  8:00   ` Li, ZhenHua
2015-01-12  8:00   ` Li, ZhenHua
2015-01-12  9:07   ` Baoquan He
2015-01-12  9:07     ` Baoquan He
2015-01-12  9:07     ` Baoquan He
2015-01-12  9:28     ` Li, ZhenHua
2015-01-12  9:28       ` Li, ZhenHua
2015-01-12  9:28       ` Li, ZhenHua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B474D5.8090500@hp.com \
    --to=zhen-hual@hp.com \
    --cc=alex.williamson@redhat.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=billsumnerlinux@gmail.com \
    --cc=ddutile@redhat.com \
    --cc=doug.hatch@hp.com \
    --cc=dwmw2@infradead.org \
    --cc=dyoung@redhat.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=ishii.hironobu@jp.fujitsu.com \
    --cc=jerry.hoemann@hp.com \
    --cc=joro@8bytes.org \
    --cc=kexec@lists.infradead.org \
    --cc=li.zhang6@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lisa.mitchell@hp.com \
    --cc=rwright@hp.com \
    --cc=tom.vaden@hp.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.