From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] mm/compaction: add tracepoint to observe behaviour of compaction defer
Date: Tue, 13 Jan 2015 09:35:26 +0100 [thread overview]
Message-ID: <54B4D8CE.3070503@suse.cz> (raw)
In-Reply-To: <20150113071839.GB29898@js1304-P5Q-DELUXE>
On 01/13/2015 08:18 AM, Joonsoo Kim wrote:
> On Mon, Jan 12, 2015 at 05:35:47PM +0100, Vlastimil Babka wrote:
>> Hm what if we avoided dirtying the cache line in the non-deferred case? Would be
>> simpler, too?
>>
>> if (zone->compact_considered + 1 >= defer_limit)
>> return false;
>>
>> zone->compact_considered++;
>>
>> trace_mm_compaction_defer_compaction(zone, order);
>>
>> return true;
>
> Okay. I will include this minor optimization in next version of this
> patch.
Hm, on second thought, the "+ 1" part would break compaction_restarting() and
it's ugly anyway. Removing "+ 1" would increase the number of
compaction_deferred() attempts until success by one. Which should be negligible,
but maybe not good to hide it in a tracepoint patch. Sorry for the noise.
> Thanks.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] mm/compaction: add tracepoint to observe behaviour of compaction defer
Date: Tue, 13 Jan 2015 09:35:26 +0100 [thread overview]
Message-ID: <54B4D8CE.3070503@suse.cz> (raw)
In-Reply-To: <20150113071839.GB29898@js1304-P5Q-DELUXE>
On 01/13/2015 08:18 AM, Joonsoo Kim wrote:
> On Mon, Jan 12, 2015 at 05:35:47PM +0100, Vlastimil Babka wrote:
>> Hm what if we avoided dirtying the cache line in the non-deferred case? Would be
>> simpler, too?
>>
>> if (zone->compact_considered + 1 >= defer_limit)
>> return false;
>>
>> zone->compact_considered++;
>>
>> trace_mm_compaction_defer_compaction(zone, order);
>>
>> return true;
>
> Okay. I will include this minor optimization in next version of this
> patch.
Hm, on second thought, the "+ 1" part would break compaction_restarting() and
it's ugly anyway. Removing "+ 1" would increase the number of
compaction_deferred() attempts until success by one. Which should be negligible,
but maybe not good to hide it in a tracepoint patch. Sorry for the noise.
> Thanks.
>
next prev parent reply other threads:[~2015-01-13 8:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 8:21 [PATCH v2 1/5] mm/compaction: change tracepoint format from decimal to hexadecimal Joonsoo Kim
2015-01-12 8:21 ` Joonsoo Kim
2015-01-12 8:21 ` [PATCH v2 2/5] mm/compaction: enhance tracepoint output for compaction begin/end Joonsoo Kim
2015-01-12 8:21 ` Joonsoo Kim
2015-01-12 14:32 ` Vlastimil Babka
2015-01-12 14:32 ` Vlastimil Babka
2015-01-12 8:21 ` [PATCH v2 3/5] mm/compaction: print current range where compaction work Joonsoo Kim
2015-01-12 8:21 ` Joonsoo Kim
2015-01-12 14:34 ` Vlastimil Babka
2015-01-12 14:34 ` Vlastimil Babka
2015-01-12 8:21 ` [PATCH v2 4/5] mm/compaction: more trace to understand when/why compaction start/finish Joonsoo Kim
2015-01-12 8:21 ` Joonsoo Kim
2015-01-12 15:53 ` Vlastimil Babka
2015-01-12 15:53 ` Vlastimil Babka
2015-01-13 7:16 ` Joonsoo Kim
2015-01-13 7:16 ` Joonsoo Kim
2015-01-13 8:29 ` Vlastimil Babka
2015-01-13 8:29 ` Vlastimil Babka
2015-01-12 8:21 ` [PATCH v2 5/5] mm/compaction: add tracepoint to observe behaviour of compaction defer Joonsoo Kim
2015-01-12 8:21 ` Joonsoo Kim
2015-01-12 16:35 ` Vlastimil Babka
2015-01-12 16:35 ` Vlastimil Babka
2015-01-13 7:18 ` Joonsoo Kim
2015-01-13 7:18 ` Joonsoo Kim
2015-01-13 8:35 ` Vlastimil Babka [this message]
2015-01-13 8:35 ` Vlastimil Babka
2015-01-12 14:23 ` [PATCH v2 1/5] mm/compaction: change tracepoint format from decimal to hexadecimal Vlastimil Babka
2015-01-12 14:23 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4D8CE.3070503@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.