All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: dont switch vt on suspend
@ 2015-01-13  8:40 Maarten Lankhorst
  2015-01-13 14:51 ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Maarten Lankhorst @ 2015-01-13  8:40 UTC (permalink / raw)
  To: Deucher, Alexander; +Cc: dri-devel@lists.freedesktop.org

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 29b9220ec399..3d201e937571 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -257,6 +257,7 @@ static int radeonfb_create(struct drm_fb_helper *helper,
 	}
 
 	info->par = rfbdev;
+	info->skip_vt_switch = true;
 
 	ret = radeon_framebuffer_init(rdev->ddev, &rfbdev->rfb, &mode_cmd, gobj);
 	if (ret) {

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/radeon: dont switch vt on suspend
  2015-01-13  8:40 [PATCH] drm/radeon: dont switch vt on suspend Maarten Lankhorst
@ 2015-01-13 14:51 ` Alex Deucher
  2015-01-13 14:55   ` Maarten Lankhorst
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2015-01-13 14:51 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: Deucher, Alexander, dri-devel@lists.freedesktop.org

On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst
<maarten.lankhorst@canonical.com> wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>

Does this fix anything or is it purely cosmetic?

Alex

> ---
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 29b9220ec399..3d201e937571 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -257,6 +257,7 @@ static int radeonfb_create(struct drm_fb_helper *helper,
>         }
>
>         info->par = rfbdev;
> +       info->skip_vt_switch = true;
>
>         ret = radeon_framebuffer_init(rdev->ddev, &rfbdev->rfb, &mode_cmd, gobj);
>         if (ret) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/radeon: dont switch vt on suspend
  2015-01-13 14:51 ` Alex Deucher
@ 2015-01-13 14:55   ` Maarten Lankhorst
  2015-01-13 14:57     ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Maarten Lankhorst @ 2015-01-13 14:55 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Deucher, Alexander, dri-devel@lists.freedesktop.org

Op 13-01-15 om 15:51 schreef Alex Deucher:
> On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst
> <maarten.lankhorst@canonical.com> wrote:
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> Does this fix anything or is it purely cosmetic?
It gets rid of unnecessarily switching to the suspend console, resulting in no longer having a xorg vt switch on suspend.

So probably just cosmetic. In nouveau it exposed a bug with LUT restore and cursor save/restore. :-)

~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/radeon: dont switch vt on suspend
  2015-01-13 14:55   ` Maarten Lankhorst
@ 2015-01-13 14:57     ` Alex Deucher
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2015-01-13 14:57 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: Deucher, Alexander, dri-devel@lists.freedesktop.org

On Tue, Jan 13, 2015 at 9:55 AM, Maarten Lankhorst
<maarten.lankhorst@canonical.com> wrote:
> Op 13-01-15 om 15:51 schreef Alex Deucher:
>> On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst
>> <maarten.lankhorst@canonical.com> wrote:
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
>> Does this fix anything or is it purely cosmetic?
> It gets rid of unnecessarily switching to the suspend console, resulting in no longer having a xorg vt switch on suspend.
>
> So probably just cosmetic. In nouveau it exposed a bug with LUT restore and cursor save/restore. :-)

Assuming it works ok,

Acked-by: Alex Deucher <alexander.deucher@amd.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-13 14:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13  8:40 [PATCH] drm/radeon: dont switch vt on suspend Maarten Lankhorst
2015-01-13 14:51 ` Alex Deucher
2015-01-13 14:55   ` Maarten Lankhorst
2015-01-13 14:57     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.