From: Vlastimil Babka <vbabka@suse.cz>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION
Date: Tue, 13 Jan 2015 10:45:17 +0100 [thread overview]
Message-ID: <54B4E92D.5050800@suse.cz> (raw)
In-Reply-To: <1453795579.577520.1420839030684.open-xchange@webmail.nmp.proximus.be>
On 01/09/2015 10:30 PM, Fabian Frederick wrote:
>
>
>> On 06 January 2015 at 18:21 Vlastimil Babka <vbabka@suse.cz> wrote:
>>
>>
>> On 01/03/2015 05:04 PM, Fabian Frederick wrote:
>> > suitable_migration_target() is only used by isolate_freepages()
>> > Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed.
>> >
>> > Fix the following warning:
>> > mm/compaction.c:311:13: warning: 'suitable_migration_target' defined
>> > but not used [-Wunused-function]
>> >
>> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>>
>> I agree, I would just move it to the section where isolation_suitable() and
>> related others are, maybe at the end of this section below
>> update_pageblock_skip()?
>
> Yes of course, that would solve the warning as well.
So, send a v2? :)
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION
Date: Tue, 13 Jan 2015 10:45:17 +0100 [thread overview]
Message-ID: <54B4E92D.5050800@suse.cz> (raw)
In-Reply-To: <1453795579.577520.1420839030684.open-xchange@webmail.nmp.proximus.be>
On 01/09/2015 10:30 PM, Fabian Frederick wrote:
>
>
>> On 06 January 2015 at 18:21 Vlastimil Babka <vbabka@suse.cz> wrote:
>>
>>
>> On 01/03/2015 05:04 PM, Fabian Frederick wrote:
>> > suitable_migration_target() is only used by isolate_freepages()
>> > Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed.
>> >
>> > Fix the following warning:
>> > mm/compaction.c:311:13: warning: 'suitable_migration_target' defined
>> > but not used [-Wunused-function]
>> >
>> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>>
>> I agree, I would just move it to the section where isolation_suitable() and
>> related others are, maybe at the end of this section below
>> update_pageblock_skip()?
>
> Yes of course, that would solve the warning as well.
So, send a v2? :)
Thanks.
next prev parent reply other threads:[~2015-01-13 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 16:04 [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION Fabian Frederick
2015-01-03 16:04 ` Fabian Frederick
2015-01-06 17:21 ` Vlastimil Babka
2015-01-06 17:21 ` Vlastimil Babka
2015-01-09 21:30 ` Fabian Frederick
2015-01-09 21:30 ` Fabian Frederick
2015-01-13 9:45 ` Vlastimil Babka [this message]
2015-01-13 9:45 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4E92D.5050800@suse.cz \
--to=vbabka@suse.cz \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.