All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Colin King <colin.king@canonical.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] static code analysis from cppcheck reports:
Date: Tue, 13 Jan 2015 13:15:33 +0000	[thread overview]
Message-ID: <54B51A75.1000308@ti.com> (raw)
In-Reply-To: <1421076472-7101-1-git-send-email-colin.king@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On 12/01/15 17:27, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> [drivers/video/fbdev/broadsheetfb.c:673]:
>   (error) Memory leak: sector_buffer
> 
> sector_buffer is not being kfree'd on each call to
> broadsheet_spiflash_rewrite_sector(), so free it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/video/fbdev/broadsheetfb.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Thanks, I've queued this for 3.19 fbdev fixes.

 Tomi




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Colin King <colin.king@canonical.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	<linux-fbdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] static code analysis from cppcheck reports:
Date: Tue, 13 Jan 2015 15:15:33 +0200	[thread overview]
Message-ID: <54B51A75.1000308@ti.com> (raw)
In-Reply-To: <1421076472-7101-1-git-send-email-colin.king@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On 12/01/15 17:27, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> [drivers/video/fbdev/broadsheetfb.c:673]:
>   (error) Memory leak: sector_buffer
> 
> sector_buffer is not being kfree'd on each call to
> broadsheet_spiflash_rewrite_sector(), so free it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/video/fbdev/broadsheetfb.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Thanks, I've queued this for 3.19 fbdev fixes.

 Tomi




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-01-13 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 15:27 [PATCH][RESEND] static code analysis from cppcheck reports: Colin King
2015-01-12 18:02 ` Geert Uytterhoeven
2015-01-12 18:02   ` Geert Uytterhoeven
2015-01-12 18:03   ` Colin Ian King
2015-01-13 13:15 ` Tomi Valkeinen [this message]
2015-01-13 13:15   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B51A75.1000308@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=colin.king@canonical.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.