From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: sirf: remove unused variable
Date: Tue, 13 Jan 2015 15:27:05 +0100 [thread overview]
Message-ID: <54B52B39.1000607@linaro.org> (raw)
In-Reply-To: <1599190.ZYSE4SrQSK@wuerfel>
On 01/13/2015 03:22 PM, Arnd Bergmann wrote:
> A recent rework of the driver left an obviously unused variable
> around, and now the compiler complains:
>
> clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
> clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div' [-Wunused-variable]
>
> Remove it.
Hi Arnd,
thanks for the fix. But this has been already fixed and merged in my
tree [1].
-- Daniel
[1]
https://git.linaro.org/people/daniel.lezcano/linux.git/commitdiff/2a016d694f36fc31f7f9fede902346c5895702bb?hp=89de77a8c557f14d2713a1f43fbc33980e639b98
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ef89af1f4380b92 ("clocksource: sirf: Remove hard-coded clock rate")
>
> diff --git a/drivers/clocksource/timer-marco.c b/drivers/clocksource/timer-marco.c
> index 361a789d4bee..3ddb81f7ee66 100644
> --- a/drivers/clocksource/timer-marco.c
> +++ b/drivers/clocksource/timer-marco.c
> @@ -257,7 +257,6 @@ static void __init sirfsoc_clockevent_init(void)
> /* initialize the kernel jiffy timer source */
> static void __init sirfsoc_marco_timer_init(struct device_node *np)
> {
> - u32 timer_div;
> struct clk *clk;
>
> clk = of_clk_get(np, 0);
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Yanchang Li <yl22@csr.com>,
Barry Song <Baohua.Song@csr.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] clocksource: sirf: remove unused variable
Date: Tue, 13 Jan 2015 15:27:05 +0100 [thread overview]
Message-ID: <54B52B39.1000607@linaro.org> (raw)
In-Reply-To: <1599190.ZYSE4SrQSK@wuerfel>
On 01/13/2015 03:22 PM, Arnd Bergmann wrote:
> A recent rework of the driver left an obviously unused variable
> around, and now the compiler complains:
>
> clocksource/timer-marco.c: In function 'sirfsoc_marco_timer_init':
> clocksource/timer-marco.c:260:6: warning: unused variable 'timer_div' [-Wunused-variable]
>
> Remove it.
Hi Arnd,
thanks for the fix. But this has been already fixed and merged in my
tree [1].
-- Daniel
[1]
https://git.linaro.org/people/daniel.lezcano/linux.git/commitdiff/2a016d694f36fc31f7f9fede902346c5895702bb?hp=89de77a8c557f14d2713a1f43fbc33980e639b98
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ef89af1f4380b92 ("clocksource: sirf: Remove hard-coded clock rate")
>
> diff --git a/drivers/clocksource/timer-marco.c b/drivers/clocksource/timer-marco.c
> index 361a789d4bee..3ddb81f7ee66 100644
> --- a/drivers/clocksource/timer-marco.c
> +++ b/drivers/clocksource/timer-marco.c
> @@ -257,7 +257,6 @@ static void __init sirfsoc_clockevent_init(void)
> /* initialize the kernel jiffy timer source */
> static void __init sirfsoc_marco_timer_init(struct device_node *np)
> {
> - u32 timer_div;
> struct clk *clk;
>
> clk = of_clk_get(np, 0);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-01-13 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:22 [PATCH] clocksource: sirf: remove unused variable Arnd Bergmann
2015-01-13 14:22 ` Arnd Bergmann
2015-01-13 14:27 ` Daniel Lezcano [this message]
2015-01-13 14:27 ` Daniel Lezcano
2015-01-13 15:24 ` Arnd Bergmann
2015-01-13 15:24 ` Arnd Bergmann
2015-01-13 15:39 ` Daniel Lezcano
2015-01-13 15:39 ` Daniel Lezcano
2015-01-13 15:24 ` Barry Song
2015-01-13 15:24 ` Barry Song
2015-01-13 16:22 ` Arnd Bergmann
2015-01-13 16:22 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 21:33 [PATCH] clocksource: sirf: Remove " Fabio Estevam
2015-01-11 14:45 ` Barry Song
2014-12-15 15:59 Thierry Reding
2014-12-15 15:59 ` Thierry Reding
2014-12-15 16:17 ` Daniel Lezcano
2014-12-15 16:17 ` Daniel Lezcano
2015-01-11 15:58 ` Barry Song
2015-01-11 15:58 ` Barry Song
2015-01-11 20:51 ` Daniel Lezcano
2015-01-11 20:51 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B52B39.1000607@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.