* [PATCH] mn88472: simplify bandwidth registers setting code
@ 2015-01-03 0:50 Benjamin Larsson
2015-01-13 16:57 ` Antti Palosaari
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Larsson @ 2015-01-03 0:50 UTC (permalink / raw)
To: crope; +Cc: Linux Media Mailing List
Signed-off-by: Benjamin Larsson <benjamin@southpole.se>
---
drivers/staging/media/mn88472/mn88472.c | 41 +++++++++++----------------------
1 file changed, 14 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index 33604dc..ee933c3 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -58,35 +58,22 @@ static int mn88472_set_frontend(struct dvb_frontend *fe)
goto err;
}
- switch (c->delivery_system) {
- case SYS_DVBT:
- case SYS_DVBT2:
- if (c->bandwidth_hz <= 5000000) {
- memcpy(bw_val, "\xe5\x99\x9a\x1b\xa9\x1b\xa9", 7);
- bw_val2 = 0x03;
- } else if (c->bandwidth_hz <= 6000000) {
- /* IF 3570000 Hz, BW 6000000 Hz */
- memcpy(bw_val, "\xbf\x55\x55\x15\x6b\x15\x6b", 7);
- bw_val2 = 0x02;
- } else if (c->bandwidth_hz <= 7000000) {
- /* IF 4570000 Hz, BW 7000000 Hz */
- memcpy(bw_val, "\xa4\x00\x00\x0f\x2c\x0f\x2c", 7);
- bw_val2 = 0x01;
- } else if (c->bandwidth_hz <= 8000000) {
- /* IF 4570000 Hz, BW 8000000 Hz */
- memcpy(bw_val, "\x8f\x80\x00\x08\xee\x08\xee", 7);
- bw_val2 = 0x00;
- } else {
- ret = -EINVAL;
- goto err;
- }
- break;
- case SYS_DVBC_ANNEX_A:
- /* IF 5070000 Hz, BW 8000000 Hz */
+ if (c->bandwidth_hz <= 5000000) {
+ memcpy(bw_val, "\xe5\x99\x9a\x1b\xa9\x1b\xa9", 7);
+ bw_val2 = 0x03;
+ } else if (c->bandwidth_hz <= 6000000) {
+ /* IF 3570000 Hz, BW 6000000 Hz */
+ memcpy(bw_val, "\xbf\x55\x55\x15\x6b\x15\x6b", 7);
+ bw_val2 = 0x02;
+ } else if (c->bandwidth_hz <= 7000000) {
+ /* IF 4570000 Hz, BW 7000000 Hz */
+ memcpy(bw_val, "\xa4\x00\x00\x0f\x2c\x0f\x2c", 7);
+ bw_val2 = 0x01;
+ } else if (c->bandwidth_hz <= 8000000) {
+ /* IF 4570000 Hz, BW 8000000 Hz */
memcpy(bw_val, "\x8f\x80\x00\x08\xee\x08\xee", 7);
bw_val2 = 0x00;
- break;
- default:
+ } else {
ret = -EINVAL;
goto err;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mn88472: simplify bandwidth registers setting code
2015-01-03 0:50 [PATCH] mn88472: simplify bandwidth registers setting code Benjamin Larsson
@ 2015-01-13 16:57 ` Antti Palosaari
0 siblings, 0 replies; 2+ messages in thread
From: Antti Palosaari @ 2015-01-13 16:57 UTC (permalink / raw)
To: Benjamin Larsson; +Cc: Linux Media Mailing List
On 01/03/2015 02:50 AM, Benjamin Larsson wrote:
> Signed-off-by: Benjamin Larsson <benjamin@southpole.se>
Reviewed-by: Antti Palosaari <crope@iki.fi>
regards
Antti
> ---
> drivers/staging/media/mn88472/mn88472.c | 41 +++++++++++----------------------
> 1 file changed, 14 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
> index 33604dc..ee933c3 100644
> --- a/drivers/staging/media/mn88472/mn88472.c
> +++ b/drivers/staging/media/mn88472/mn88472.c
> @@ -58,35 +58,22 @@ static int mn88472_set_frontend(struct dvb_frontend *fe)
> goto err;
> }
>
> - switch (c->delivery_system) {
> - case SYS_DVBT:
> - case SYS_DVBT2:
> - if (c->bandwidth_hz <= 5000000) {
> - memcpy(bw_val, "\xe5\x99\x9a\x1b\xa9\x1b\xa9", 7);
> - bw_val2 = 0x03;
> - } else if (c->bandwidth_hz <= 6000000) {
> - /* IF 3570000 Hz, BW 6000000 Hz */
> - memcpy(bw_val, "\xbf\x55\x55\x15\x6b\x15\x6b", 7);
> - bw_val2 = 0x02;
> - } else if (c->bandwidth_hz <= 7000000) {
> - /* IF 4570000 Hz, BW 7000000 Hz */
> - memcpy(bw_val, "\xa4\x00\x00\x0f\x2c\x0f\x2c", 7);
> - bw_val2 = 0x01;
> - } else if (c->bandwidth_hz <= 8000000) {
> - /* IF 4570000 Hz, BW 8000000 Hz */
> - memcpy(bw_val, "\x8f\x80\x00\x08\xee\x08\xee", 7);
> - bw_val2 = 0x00;
> - } else {
> - ret = -EINVAL;
> - goto err;
> - }
> - break;
> - case SYS_DVBC_ANNEX_A:
> - /* IF 5070000 Hz, BW 8000000 Hz */
> + if (c->bandwidth_hz <= 5000000) {
> + memcpy(bw_val, "\xe5\x99\x9a\x1b\xa9\x1b\xa9", 7);
> + bw_val2 = 0x03;
> + } else if (c->bandwidth_hz <= 6000000) {
> + /* IF 3570000 Hz, BW 6000000 Hz */
> + memcpy(bw_val, "\xbf\x55\x55\x15\x6b\x15\x6b", 7);
> + bw_val2 = 0x02;
> + } else if (c->bandwidth_hz <= 7000000) {
> + /* IF 4570000 Hz, BW 7000000 Hz */
> + memcpy(bw_val, "\xa4\x00\x00\x0f\x2c\x0f\x2c", 7);
> + bw_val2 = 0x01;
> + } else if (c->bandwidth_hz <= 8000000) {
> + /* IF 4570000 Hz, BW 8000000 Hz */
> memcpy(bw_val, "\x8f\x80\x00\x08\xee\x08\xee", 7);
> bw_val2 = 0x00;
> - break;
> - default:
> + } else {
> ret = -EINVAL;
> goto err;
> }
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-03 0:50 [PATCH] mn88472: simplify bandwidth registers setting code Benjamin Larsson
2015-01-13 16:57 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.