Re: [PATCH] cx23885/vb2 regression: please test this patch

[Raimonds Cicans <ray@apollo.lv>]

On 13.01.2015 16:01, Hans Verkuil wrote:
> Hi Raimonds, Jurgen,
>
> Can you both test this patch? It should (I hope) solve the problems you
> both had with the cx23885 driver.
>
> This patch fixes a race condition in the vb2_thread that occurs when
> the thread is stopped. The crucial fix is calling kthread_stop much
> earlier in vb2_thread_stop(). But I also made the vb2_thread more
> robust.

With this patch I am unable to get any error except first
(AMD-Vi: Event logged [IO_PAGE_FAULT...).
But I am not convinced, because before patch I get
first error much often and earlier than almost any other error,
so it may be just "bad luck" and other errors do not
appear because first error appear earlier.

BTW question about RISC engine:
what kind of memory use RISC engine to store
DMA programs (code)? Internal SRAM or host's?
I ask because "cx23885[0]: mpeg risc op code error"
error message storm after first message looks like
RISC engine used host's memory when this memory
was unmapped.



Raimonds Cicans