Re: [PATCH] mm: vmscan: fix the page state calculation in too_many_isolated

[Vinayak Menon <vinmenon@codeaurora.org>]

On 01/13/2015 09:39 PM, Johannes Weiner wrote:
> On Tue, Jan 13, 2015 at 04:37:27PM +0530, Vinayak Menon wrote:
>> @@ -1392,6 +1392,44 @@ int isolate_lru_page(struct page *page)
>>   	return ret;
>>   }
>>
>> +static int __too_many_isolated(struct zone *zone, int file,
>> +	struct scan_control *sc, int safe)
>> +{
>> +	unsigned long inactive, isolated;
>> +
>> +	if (file) {
>> +		if (safe) {
>> +			inactive = zone_page_state_snapshot(zone,
>> +					NR_INACTIVE_FILE);
>> +			isolated = zone_page_state_snapshot(zone,
>> +					NR_ISOLATED_FILE);
>> +		} else {
>> +			inactive = zone_page_state(zone, NR_INACTIVE_FILE);
>> +			isolated = zone_page_state(zone, NR_ISOLATED_FILE);
>> +		}
>> +	} else {
>> +		if (safe) {
>> +			inactive = zone_page_state_snapshot(zone,
>> +					NR_INACTIVE_ANON);
>> +			isolated = zone_page_state_snapshot(zone,
>> +					NR_ISOLATED_ANON);
>> +		} else {
>> +			inactive = zone_page_state(zone, NR_INACTIVE_ANON);
>> +			isolated = zone_page_state(zone, NR_ISOLATED_ANON);
>> +		}
>> +	}
>
> 	if (safe) {
> 		inactive = zone_page_state_snapshot(zone, NR_INACTIVE_ANON + 2*file)
> 		isolated = zone_page_state_snapshot(zone, NR_ISOLATED_ANON + file)
> 	} else {
> 		inactive = zone_page_state(zone, NR_INACTIVE_ANON + 2*file)
> 		isolated = zone_page_state(zone, NR_ISOLATED_ANON + file)
> 	}
>

Ok. Will change that.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>