From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros
Date: Wed, 14 Jan 2015 06:31:33 -0700 [thread overview]
Message-ID: <54B66FB5.6000101@redhat.com> (raw)
In-Reply-To: <1421171432-8733-10-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On 01/13/2015 10:50 AM, Markus Armbruster wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> They're used with error_set() and qerror_report(), and expand into the
> first *two* arguments. This trickiness has become pointless. Clean
> up.
I like your wording in 6/9 better ("Clean this one up"), as it is more
obvious that you are only fixing a subset and not eliminating all such
macros.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> balloon.c | 6 ++++--
> include/qapi/qmp/qerror.h | 6 ------
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
For this patch, and for all others in the series where I did not
explicitly reply,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-14 13:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:50 [Qemu-devel] [PATCH 0/9] qmp hmp balloon: Cleanups around error reporting Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test Markus Armbruster
2015-01-14 13:10 ` Eric Blake
2015-01-14 13:53 ` Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use Markus Armbruster
2015-01-14 13:16 ` Eric Blake
2015-01-14 13:51 ` Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 3/9] hmp: Compile hmp_info_spice() only with CONFIG_SPICE Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy Markus Armbruster
2015-01-14 13:26 ` Eric Blake
2015-01-13 17:50 ` [Qemu-devel] [PATCH 5/9] qmp: Simplify recognition of capability negotiation command Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 6/9] qmp: Eliminate silly QERR_COMMAND_NOT_FOUND macro Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 7/9] balloon: Inline qemu_balloon(), qemu_balloon_status() Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test Markus Armbruster
2015-01-14 13:29 ` Eric Blake
2015-01-14 14:34 ` Markus Armbruster
2015-02-10 18:39 ` Dr. David Alan Gilbert
2015-02-10 22:42 ` Eric Blake
2015-02-11 12:12 ` Markus Armbruster
2015-01-13 17:50 ` [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros Markus Armbruster
2015-01-14 13:31 ` Eric Blake [this message]
2015-01-14 7:23 ` [Qemu-devel] [PATCH 0/9] qmp hmp balloon: Cleanups around error reporting Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B66FB5.6000101@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.