Re: [PATCH 1/3] ovl: print error message for invalid mount options

[hujianyang <hujianyang@huawei.com>]

On 2015/1/15 13:17, hujianyang wrote:
> Overlayfs should print an error message if an incorrect mount option
> is caught like other filesystems.
> 
> After this patch, improper option input could be clearly known.
> 
> Reported-by: Fabian Sturm <fabian.sturm@aduu.de>
> Signed-off-by: hujianyang <hujianyang@huawei.com>
> ---
>  fs/overlayfs/super.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index b90952f..ab3c8cb 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -615,6 +615,7 @@ static int ovl_parse_opt(char *opt, struct ovl_config *config)
>  			break;
> 
>  		default:
> +			pr_err("overlayfs: unrecognized mount option \"%s\" or missing value\n", p);

Hi Miklos,

I'm sorry. The parameter "p" should begin with a new line.

I'd like to resend a new patch after you review these patches.

Thanks,
Hu

>  			return -EINVAL;
>  		}
>  	}
>