All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Vrabel <david.vrabel@citrix.com>, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
	kvm-ppc@vger.kernel.org, linux-mm@kvack.org,
	xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE
Date: Thu, 15 Jan 2015 11:07:11 +0000	[thread overview]
Message-ID: <54B79F5F.1040806@de.ibm.com> (raw)
In-Reply-To: <54B799DC.1050008@citrix.com>

Am 15.01.2015 um 11:43 schrieb David Vrabel:
> On 15/01/15 08:58, Christian Borntraeger wrote:
>> ACCESS_ONCE does not work reliably on non-scalar types. For
>> example gcc 4.6 and 4.7 might remove the volatile tag for such
>> accesses during the SRA (scalar replacement of aggregates) step
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?idX145)
>>
>> Change the p2m code to replace ACCESS_ONCE with READ_ONCE.
> 
> Acked-by: David Vrabel <david.vrabel@citrix.com>

Thanks

> Let me know if you want me to merge this via the Xen tree.


With your Acked-by, I can easily carry this in my tree. We can 
then ensure that this patch is merged before the ACCESS_ONCE is
made stricter - making bisecting easier.

Christian


WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Vrabel <david.vrabel@citrix.com>, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
	kvm-ppc@vger.kernel.org, linux-mm@kvack.org,
	xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE
Date: Thu, 15 Jan 2015 12:07:11 +0100	[thread overview]
Message-ID: <54B79F5F.1040806@de.ibm.com> (raw)
In-Reply-To: <54B799DC.1050008@citrix.com>

Am 15.01.2015 um 11:43 schrieb David Vrabel:
> On 15/01/15 08:58, Christian Borntraeger wrote:
>> ACCESS_ONCE does not work reliably on non-scalar types. For
>> example gcc 4.6 and 4.7 might remove the volatile tag for such
>> accesses during the SRA (scalar replacement of aggregates) step
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
>>
>> Change the p2m code to replace ACCESS_ONCE with READ_ONCE.
> 
> Acked-by: David Vrabel <david.vrabel@citrix.com>

Thanks

> Let me know if you want me to merge this via the Xen tree.


With your Acked-by, I can easily carry this in my tree. We can 
then ensure that this patch is merged before the ACCESS_ONCE is
made stricter - making bisecting easier.

Christian

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Vrabel <david.vrabel@citrix.com>, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
	kvm-ppc@vger.kernel.org, linux-mm@kvack.org,
	xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Xen-devel] [PATCH 3/8] x86/xen/p2m: Replace ACCESS_ONCE with READ_ONCE
Date: Thu, 15 Jan 2015 12:07:11 +0100	[thread overview]
Message-ID: <54B79F5F.1040806@de.ibm.com> (raw)
Message-ID: <20150115110711.mBgFH8pNXmKEY41UcSsNd2lzMZ0_Y5nvlLA_OQzZPEM@z> (raw)
In-Reply-To: <54B799DC.1050008@citrix.com>

Am 15.01.2015 um 11:43 schrieb David Vrabel:
> On 15/01/15 08:58, Christian Borntraeger wrote:
>> ACCESS_ONCE does not work reliably on non-scalar types. For
>> example gcc 4.6 and 4.7 might remove the volatile tag for such
>> accesses during the SRA (scalar replacement of aggregates) step
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
>>
>> Change the p2m code to replace ACCESS_ONCE with READ_ONCE.
> 
> Acked-by: David Vrabel <david.vrabel@citrix.com>

Thanks

> Let me know if you want me to merge this via the Xen tree.


With your Acked-by, I can easily carry this in my tree. We can 
then ensure that this patch is merged before the ACCESS_ONCE is
made stricter - making bisecting easier.

Christian


  reply	other threads:[~2015-01-15 11:07 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15  8:58 [PATCH 0/8] current ACCESS_ONCE patch queue Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15 23:09   ` Michael Ellerman
2015-01-15 23:09   ` Michael Ellerman
2015-01-15 23:09     ` Michael Ellerman
2015-01-15 23:09     ` Michael Ellerman
2015-01-15 23:09     ` Michael Ellerman
2015-01-16  9:43     ` Christian Borntraeger
2015-01-16  9:43     ` Christian Borntraeger
2015-01-16  9:43       ` Christian Borntraeger
2015-01-16  9:43       ` Christian Borntraeger
2015-01-16  9:43       ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 2/8] ppc/hugetlbfs: " Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 3/8] x86/xen/p2m: " Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  9:26   ` Jürgen Groß
2015-01-15  9:26   ` Jürgen Groß
2015-01-15  9:26     ` Jürgen Groß
2015-01-15  9:26     ` Jürgen Groß
2015-01-15  9:26     ` Jürgen Groß
2015-01-15 10:43   ` [Xen-devel] " David Vrabel
2015-01-15 10:43     ` David Vrabel
2015-01-15 10:43     ` David Vrabel
2015-01-15 10:43     ` David Vrabel
2015-01-15 10:43     ` David Vrabel
2015-01-15 11:07     ` Christian Borntraeger [this message]
2015-01-15 11:07       ` Christian Borntraeger
2015-01-15 11:07       ` Christian Borntraeger
2015-01-15 11:07     ` Christian Borntraeger
2015-01-15 10:43   ` David Vrabel
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15 19:38   ` Oleg Nesterov
2015-01-15 19:38   ` Oleg Nesterov
2015-01-15 19:38     ` Oleg Nesterov
2015-01-15 19:38     ` Oleg Nesterov
2015-01-15 19:38     ` Oleg Nesterov
2015-01-15 19:51     ` Christian Borntraeger
2015-01-15 19:51     ` Christian Borntraeger
2015-01-15 19:51       ` Christian Borntraeger
2015-01-15 19:51       ` Christian Borntraeger
2015-01-15 19:51       ` Christian Borntraeger
2015-01-15 20:01       ` Oleg Nesterov
2015-01-15 20:01         ` Oleg Nesterov
2015-01-15 20:01         ` Oleg Nesterov
2015-01-15 20:01         ` Oleg Nesterov
2015-01-15 21:00         ` Christian Borntraeger
2015-01-15 21:00           ` Christian Borntraeger
2015-01-15 21:00           ` Christian Borntraeger
2015-01-15 21:00           ` Christian Borntraeger
2015-01-15 21:00         ` Christian Borntraeger
2015-01-15 20:01       ` Oleg Nesterov
2015-01-15  8:58 ` [PATCH 5/8] mm/gup: Replace ACCESS_ONCE with READ_ONCE Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 6/8] kernel: tighten rules for ACCESS ONCE Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 7/8] next: sh: Fix compile error Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58 ` [PATCH 8/8] kernel: Fix sparse warning for ACCESS_ONCE Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58   ` Christian Borntraeger
2015-01-15  8:58 ` Christian Borntraeger
2015-01-16 12:12 ` [PATCH 0/8] current ACCESS_ONCE patch queue Alexander Graf
2015-01-16 12:12   ` Alexander Graf
2015-01-16 12:12   ` Alexander Graf
2015-01-16 12:12   ` Alexander Graf
2015-01-16 12:12 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B79F5F.1040806@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=david.vrabel@citrix.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.