All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	LFBDEV <linux-fbdev@vger.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()
Date: Thu, 15 Jan 2015 11:26:47 +0000	[thread overview]
Message-ID: <54B7A3F7.8010107@ti.com> (raw)
In-Reply-To: <1421090474-4243-1-git-send-email-prabhakar.csengg@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On 12/01/15 21:21, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  drivers/video/fbdev/ssd1307fb.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a7ecaa6..c891f11 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
>  	return ret;
>  }
>  
> -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
> -{
> -	struct ssd1307fb_array *array;
> -	int ret;
> -
> -	array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
> -	if (!array)
> -		return -ENOMEM;
> -
> -	array->data[0] = data;
> -
> -	ret = ssd1307fb_write_array(client, array, 1);
> -	kfree(array);
> -
> -	return ret;
> -}
> -
>  static void ssd1307fb_update_display(struct ssd1307fb_par *par)
>  {
>  	struct ssd1307fb_array *array;
> 

Thanks, queued for 3.20.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	LFBDEV <linux-fbdev@vger.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()
Date: Thu, 15 Jan 2015 13:26:47 +0200	[thread overview]
Message-ID: <54B7A3F7.8010107@ti.com> (raw)
In-Reply-To: <1421090474-4243-1-git-send-email-prabhakar.csengg@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On 12/01/15 21:21, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  drivers/video/fbdev/ssd1307fb.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a7ecaa6..c891f11 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
>  	return ret;
>  }
>  
> -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
> -{
> -	struct ssd1307fb_array *array;
> -	int ret;
> -
> -	array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
> -	if (!array)
> -		return -ENOMEM;
> -
> -	array->data[0] = data;
> -
> -	ret = ssd1307fb_write_array(client, array, 1);
> -	kfree(array);
> -
> -	return ret;
> -}
> -
>  static void ssd1307fb_update_display(struct ssd1307fb_par *par)
>  {
>  	struct ssd1307fb_array *array;
> 

Thanks, queued for 3.20.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-01-15 11:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 19:21 [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data() Lad, Prabhakar
2015-01-13 13:43 ` Maxime Ripard
2015-01-13 13:43   ` Maxime Ripard
2015-01-15 11:26 ` Tomi Valkeinen [this message]
2015-01-15 11:26   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B7A3F7.8010107@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=prabhakar.csengg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.