From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15
Date: Thu, 15 Jan 2015 13:08:50 +0100 [thread overview]
Message-ID: <54B7ADD2.5080302@redhat.com> (raw)
In-Reply-To: <CAFEAcA9mrdbduNh909Lc3fj=BtL+3c+rVs1aiiYhxSwg7as-sQ@mail.gmail.com>
On 15/01/2015 12:55, Peter Maydell wrote:
> > With the introduction of pbonzini's "misc" patches tree I'm not
> > sure current trivial-patches is worth to keep. Paolo does much
> > better job in this area than me.
>
> I'll leave that up to the two of you, but splitting the load
> of review and testing seems to me like it would make sense.
> In any case, thanks to both of you for the efforts you've
> put in to this sort of patch curation -- I think it's really
> important for the project.
The trivial patches tree is still very useful.
The meaning of "misc patches" is almost always "I don't want to send a
separate pull request because this is touching too many areas"
(typically three or more among: qemu-char, SCSI, KVM, x86, and stuff
that I touched and got a Reviewed-by).
5-10% of the "misc patches", instead, correspond to unmaintained
areas---basically the patches that Anthony used to apply directly---but
luckily by now there are very few of those.
In any case, most patches in the "misc patches" pull request are not
trivial. They could very well break something and if they do I
sometimes get to fix them... which is why I'm very happy that someone
else picks up the _really_ trivial patches!
So, the trivial patches tree is still as useful as it has always been,
and I use it myself relatively often for patches outside the areas I
maintain.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15
Date: Thu, 15 Jan 2015 13:08:50 +0100 [thread overview]
Message-ID: <54B7ADD2.5080302@redhat.com> (raw)
In-Reply-To: <CAFEAcA9mrdbduNh909Lc3fj=BtL+3c+rVs1aiiYhxSwg7as-sQ@mail.gmail.com>
On 15/01/2015 12:55, Peter Maydell wrote:
> > With the introduction of pbonzini's "misc" patches tree I'm not
> > sure current trivial-patches is worth to keep. Paolo does much
> > better job in this area than me.
>
> I'll leave that up to the two of you, but splitting the load
> of review and testing seems to me like it would make sense.
> In any case, thanks to both of you for the efforts you've
> put in to this sort of patch curation -- I think it's really
> important for the project.
The trivial patches tree is still very useful.
The meaning of "misc patches" is almost always "I don't want to send a
separate pull request because this is touching too many areas"
(typically three or more among: qemu-char, SCSI, KVM, x86, and stuff
that I touched and got a Reviewed-by).
5-10% of the "misc patches", instead, correspond to unmaintained
areas---basically the patches that Anthony used to apply directly---but
luckily by now there are very few of those.
In any case, most patches in the "misc patches" pull request are not
trivial. They could very well break something and if they do I
sometimes get to fix them... which is why I'm very happy that someone
else picks up the _really_ trivial patches!
So, the trivial patches tree is still as useful as it has always been,
and I use it myself relatively often for patches outside the areas I
maintain.
Paolo
next prev parent reply other threads:[~2015-01-15 12:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 8:30 [Qemu-trivial] [PULL 00/12] Trivial patches for 2015-01-15 Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 02/12] tests/hd-geo-test.c: Remove unused test_image variable Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 03/12] translate-all: Mark map_exec() with the 'unused' attribute Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 05/12] target-tricore: Fix new typos Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 06/12] target-arm: Fix typo in comment (seperately -> separately) Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 07/12] misc: Fix new typos in comments Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 08/12] Do not hang on full PTY Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 09/12] target-openrisc: bugfix for dec_sys to decode instructions correctly Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 10/12] Makefile: Remove config.status and common.env during 'make distclean' Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 11/12] blizzard: do not depend on VGA internals Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 8:30 ` [Qemu-trivial] [PULL 12/12] vl.c: fix some alignment issues Michael Tokarev
2015-01-15 8:30 ` [Qemu-devel] " Michael Tokarev
2015-01-15 11:55 ` [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15 Peter Maydell
2015-01-15 11:55 ` Peter Maydell
2015-01-15 12:08 ` Paolo Bonzini [this message]
2015-01-15 12:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7ADD2.5080302@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.