* [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-14 9:18 ` Bart Tanghe
0 siblings, 0 replies; 8+ messages in thread
From: Bart Tanghe @ 2015-01-14 9:18 UTC (permalink / raw)
To: swarren, lee
Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, linux, devicetree, linux-arm-kernel, linux-rpi-kernel,
linux-kernel, Bart Tanghe
To probe the bcm2835-pwm driver properly, this dts bindings has to be added
to the bcm2835 dtsi file.
In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
---
Changes in v3:
- node added by reg value
Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..ba76bb4 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -146,6 +147,14 @@
interrupts = <1 9>;
};
+ pwm: pwm@7e20e000 {
+ compatible = "brcm,bcm2835-pwm";
+ reg = <0x7e20c000 0x28>;
+ clocks = <&clk_pwm>;
+ #pwm-cells = <2>;
+ status = "disabled";
+ };
+
arm-pmu {
compatible = "arm,arm1176-pmu";
};
@@ -179,5 +188,13 @@
clock-output-names = "spi";
clock-frequency = <250000000>;
};
+
+ clk_pwm: clock@3 {
+ compatible = "fixed-clock";
+ reg = <3>;
+ #clock-cells = <0>;
+ clock-output-names = "pwm";
+ clock-frequency = <9200000>;
+ };
};
};
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-14 9:18 ` Bart Tanghe
0 siblings, 0 replies; 8+ messages in thread
From: Bart Tanghe @ 2015-01-14 9:18 UTC (permalink / raw)
To: swarren-3lzwWm7+Weoh9ZMKESR00Q, lee-DgEjT+Ai2ygdnm+yROfE0A
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Bart Tanghe
To probe the bcm2835-pwm driver properly, this dts bindings has to be added
to the bcm2835 dtsi file.
In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
---
Changes in v3:
- node added by reg value
Signed-off-by: Bart Tanghe <bart.tanghe-2dq7lIxLGp5qkBXjtECzWg@public.gmane.org>
Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..ba76bb4 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -146,6 +147,14 @@
interrupts = <1 9>;
};
+ pwm: pwm@7e20e000 {
+ compatible = "brcm,bcm2835-pwm";
+ reg = <0x7e20c000 0x28>;
+ clocks = <&clk_pwm>;
+ #pwm-cells = <2>;
+ status = "disabled";
+ };
+
arm-pmu {
compatible = "arm,arm1176-pmu";
};
@@ -179,5 +188,13 @@
clock-output-names = "spi";
clock-frequency = <250000000>;
};
+
+ clk_pwm: clock@3 {
+ compatible = "fixed-clock";
+ reg = <3>;
+ #clock-cells = <0>;
+ clock-output-names = "pwm";
+ clock-frequency = <9200000>;
+ };
};
};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-14 17:06 ` Stephen Warren
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2015-01-14 17:06 UTC (permalink / raw)
To: linux-arm-kernel
On 01/14/2015 02:18 AM, Bart Tanghe wrote:
> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
> to the bcm2835 dtsi file.
> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
> ---
> Changes in v3:
> - node added by reg value
The pwm node still seems to be in the wrong place. Sorting by reg value,
it should be after i2c at 20205000 and before sdhci at 7e300000, as I
mentioned before.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-14 17:06 ` Stephen Warren
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2015-01-14 17:06 UTC (permalink / raw)
To: Bart Tanghe, lee
Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, linux, devicetree, linux-arm-kernel, linux-rpi-kernel,
linux-kernel
On 01/14/2015 02:18 AM, Bart Tanghe wrote:
> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
> to the bcm2835 dtsi file.
> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
> ---
> Changes in v3:
> - node added by reg value
The pwm node still seems to be in the wrong place. Sorting by reg value,
it should be after i2c@20205000 and before sdhci@7e300000, as I
mentioned before.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-14 17:06 ` Stephen Warren
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Warren @ 2015-01-14 17:06 UTC (permalink / raw)
To: Bart Tanghe, lee-DgEjT+Ai2ygdnm+yROfE0A
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 01/14/2015 02:18 AM, Bart Tanghe wrote:
> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
> to the bcm2835 dtsi file.
> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
> ---
> Changes in v3:
> - node added by reg value
The pwm node still seems to be in the wrong place. Sorting by reg value,
it should be after i2c@20205000 and before sdhci@7e300000, as I
mentioned before.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] ARM: dts: add bcm2835-pwm bindings
2015-01-14 17:06 ` Stephen Warren
@ 2015-01-15 12:29 ` Bart Tanghe
-1 siblings, 0 replies; 8+ messages in thread
From: Bart Tanghe @ 2015-01-15 12:29 UTC (permalink / raw)
To: linux-arm-kernel
I'm really sorry. I've used the wrong source. I make v4.
Regards,
Bart
On 01/14/2015 06:06 PM, Stephen Warren wrote:
> On 01/14/2015 02:18 AM, Bart Tanghe wrote:
>> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
>> to the bcm2835 dtsi file.
>> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
>> ---
>> Changes in v3:
>> - node added by reg value
>
> The pwm node still seems to be in the wrong place. Sorting by reg value, it should be after i2c at 20205000 and before sdhci at 7e300000, as I mentioned before.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-15 12:29 ` Bart Tanghe
0 siblings, 0 replies; 8+ messages in thread
From: Bart Tanghe @ 2015-01-15 12:29 UTC (permalink / raw)
To: Stephen Warren, lee
Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, linux, devicetree, linux-arm-kernel, linux-rpi-kernel,
linux-kernel
I'm really sorry. I've used the wrong source. I make v4.
Regards,
Bart
On 01/14/2015 06:06 PM, Stephen Warren wrote:
> On 01/14/2015 02:18 AM, Bart Tanghe wrote:
>> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
>> to the bcm2835 dtsi file.
>> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
>> ---
>> Changes in v3:
>> - node added by reg value
>
> The pwm node still seems to be in the wrong place. Sorting by reg value, it should be after i2c@20205000 and before sdhci@7e300000, as I mentioned before.
^ permalink raw reply [flat|nested] 8+ messages in thread