All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen: arm: enable sync console in machine_reboot.
Date: Thu, 15 Jan 2015 12:57:36 +0000	[thread overview]
Message-ID: <54B7B940.7000909@linaro.org> (raw)
In-Reply-To: <1421320947-17049-1-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 15/01/15 11:22, Ian Campbell wrote:
> Otherwise the last thing printed is "(XE" or something.
> 
> In line with x86 also disable the watchdog and spin debugging.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

> ---
>  xen/arch/arm/shutdown.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> index 4988b03..e53ec97 100644
> --- a/xen/arch/arm/shutdown.c
> +++ b/xen/arch/arm/shutdown.c
> @@ -38,6 +38,10 @@ void machine_restart(unsigned int delay_millisecs)
>  {
>      int timeout = 10;
>  
> +    watchdog_disable();

OOI, it looks like watchdog_disable is a no-op on ARM. Is there any plan
to implement it?

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-01-15 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 11:22 [PATCH] xen: arm: enable sync console in machine_reboot Ian Campbell
2015-01-15 12:57 ` Julien Grall [this message]
2015-01-15 13:00   ` Ian Campbell
2015-01-27 17:21   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B7B940.7000909@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.