* [PATCH] xen: arm: enable sync console in machine_reboot.
@ 2015-01-15 11:22 Ian Campbell
2015-01-15 12:57 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2015-01-15 11:22 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Otherwise the last thing printed is "(XE" or something.
In line with x86 also disable the watchdog and spin debugging.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/shutdown.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
index 4988b03..e53ec97 100644
--- a/xen/arch/arm/shutdown.c
+++ b/xen/arch/arm/shutdown.c
@@ -38,6 +38,10 @@ void machine_restart(unsigned int delay_millisecs)
{
int timeout = 10;
+ watchdog_disable();
+ console_start_sync();
+ spin_debug_disable();
+
local_irq_enable();
smp_call_function(halt_this_cpu, NULL, 0);
local_irq_disable();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xen: arm: enable sync console in machine_reboot.
2015-01-15 11:22 [PATCH] xen: arm: enable sync console in machine_reboot Ian Campbell
@ 2015-01-15 12:57 ` Julien Grall
2015-01-15 13:00 ` Ian Campbell
2015-01-27 17:21 ` Ian Campbell
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2015-01-15 12:57 UTC (permalink / raw)
To: Ian Campbell, xen-devel; +Cc: tim, stefano.stabellini
Hi Ian,
On 15/01/15 11:22, Ian Campbell wrote:
> Otherwise the last thing printed is "(XE" or something.
>
> In line with x86 also disable the watchdog and spin debugging.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Reviewed-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/shutdown.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> index 4988b03..e53ec97 100644
> --- a/xen/arch/arm/shutdown.c
> +++ b/xen/arch/arm/shutdown.c
> @@ -38,6 +38,10 @@ void machine_restart(unsigned int delay_millisecs)
> {
> int timeout = 10;
>
> + watchdog_disable();
OOI, it looks like watchdog_disable is a no-op on ARM. Is there any plan
to implement it?
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xen: arm: enable sync console in machine_reboot.
2015-01-15 12:57 ` Julien Grall
@ 2015-01-15 13:00 ` Ian Campbell
2015-01-27 17:21 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-01-15 13:00 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Thu, 2015-01-15 at 12:57 +0000, Julien Grall wrote:
> Hi Ian,
>
> On 15/01/15 11:22, Ian Campbell wrote:
> > Otherwise the last thing printed is "(XE" or something.
> >
> > In line with x86 also disable the watchdog and spin debugging.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>
>
> > ---
> > xen/arch/arm/shutdown.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> > index 4988b03..e53ec97 100644
> > --- a/xen/arch/arm/shutdown.c
> > +++ b/xen/arch/arm/shutdown.c
> > @@ -38,6 +38,10 @@ void machine_restart(unsigned int delay_millisecs)
> > {
> > int timeout = 10;
> >
> > + watchdog_disable();
>
> OOI, it looks like watchdog_disable is a no-op on ARM. Is there any plan
> to implement it?
Not by me, would be nice to have though.
>
> Regards,
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xen: arm: enable sync console in machine_reboot.
2015-01-15 12:57 ` Julien Grall
2015-01-15 13:00 ` Ian Campbell
@ 2015-01-27 17:21 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2015-01-27 17:21 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Thu, 2015-01-15 at 12:57 +0000, Julien Grall wrote:
> Hi Ian,
>
> On 15/01/15 11:22, Ian Campbell wrote:
> > Otherwise the last thing printed is "(XE" or something.
> >
> > In line with x86 also disable the watchdog and spin debugging.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-27 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 11:22 [PATCH] xen: arm: enable sync console in machine_reboot Ian Campbell
2015-01-15 12:57 ` Julien Grall
2015-01-15 13:00 ` Ian Campbell
2015-01-27 17:21 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.