From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>,
Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Eddie Dong <eddie.dong@intel.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for-4.5 v7 3/7] vmware: Add VMware provided include files.
Date: Thu, 15 Jan 2015 16:36:34 -0500 [thread overview]
Message-ID: <54B832E2.4010706@terremark.com> (raw)
In-Reply-To: <54B7FCF2020000780005589A@mail.emea.novell.com>
On 01/15/15 11:46, Jan Beulich wrote:
>>>> On 02.10.14 at 23:30, <dslutz@verizon.com> wrote:
>> These 2 files: backdoor_def.h and guest_msg_def.h come from:
>>
>> http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html
>> open-vm-tools-kmod-7.4.8-396269.423167.src.rpm
>> open-vm-tools-kmod-7.4.8.tar.gz
>> vmhgfs/backdoor_def.h
>> vmhgfs/guest_msg_def.h
>>
>> and are unchanged.
>
> Either the description is wrong, or the patch is stale - there's no
> guest_msg_def.h here.
>
The commit message is stale. Missed adjusting for removal of VMware
rpc stuff. Will Fix.
>> Added the badly named include file includeCheck.h also. It only
>> has comments and is provided so that backdoor_def.h and
>> guest_msg_def.h can be used without change.
>
> In which case I'd say a file with a single comment line in it would
> suffice. Such a comment is hardly copyrightable...
>
Ok, Will make it a single line comment.
-Don Slutz
> Jan
>
next prev parent reply other threads:[~2015-01-15 21:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 21:30 [PATCH for-4.5 v7 0/7] Xen VMware tools support Don Slutz
2014-10-02 21:30 ` [PATCH for-4.5 v7 1/7] xen: Add support for VMware cpuid leaves Don Slutz
2015-01-15 16:42 ` Jan Beulich
2015-01-15 21:00 ` Don Slutz
2015-01-16 7:57 ` Jan Beulich
2015-01-16 19:21 ` Don Slutz
2014-10-02 21:30 ` [PATCH for-4.5 v7 2/7] tools: Add vmware_hw support Don Slutz
2014-10-02 22:21 ` Andrew Cooper
2014-10-02 22:56 ` [PATCH for-4.5 v8 " Don Slutz
2014-10-02 21:30 ` [PATCH for-4.5 v7 3/7] vmware: Add VMware provided include files Don Slutz
2015-01-15 16:46 ` Jan Beulich
2015-01-15 21:36 ` Don Slutz [this message]
2014-10-02 21:30 ` [PATCH for-4.5 v7 4/7] xen: Add vmware_port support Don Slutz
2014-10-02 21:58 ` Don Slutz
2014-10-02 22:40 ` [PATCH for-4.5 v8 " Don Slutz
2015-01-16 10:09 ` Jan Beulich
2015-01-21 17:52 ` Don Slutz
2015-01-22 8:32 ` Jan Beulich
2015-01-26 15:58 ` Don Slutz
2015-01-26 16:46 ` Jan Beulich
2015-01-26 20:19 ` Don Slutz
2015-01-27 7:58 ` Jan Beulich
2015-01-28 8:19 ` Jan Beulich
2015-01-28 22:47 ` Don Slutz
2015-01-29 0:32 ` Don Slutz
2015-02-10 19:30 ` [PATCH " Don Slutz
2015-02-11 7:56 ` Jan Beulich
2015-02-11 17:04 ` Andrew Cooper
2015-02-17 7:45 ` Jan Beulich
2014-10-02 21:30 ` [PATCH for-4.5 v7 5/7] tools: " Don Slutz
2014-10-02 21:30 ` [PATCH for-4.5 v7 6/7] Add xentrace to vmware_port Don Slutz
2014-10-02 21:30 ` [OPTIONAL][PATCH for-4.5 v7 7/7] Add xen-hvm-param Don Slutz
2014-10-16 8:12 ` [PATCH for-4.5 v7 0/7] Xen VMware tools support Jan Beulich
2014-10-16 12:10 ` Don Slutz
2014-10-16 12:17 ` Ian Jackson
2014-10-16 12:22 ` Jan Beulich
2014-10-16 12:58 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B832E2.4010706@terremark.com \
--to=dslutz@verizon.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.