All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon
Date: Fri, 16 Jan 2015 11:19:53 +0100	[thread overview]
Message-ID: <54B8E5C9.5090006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1421377361.18166.2.camel@ellerman.id.au>

On 16/01/2015 04:02, Michael Ellerman wrote:
> On Thu, 2015-01-15 at 15:41 -0800, Tyrel Datwyler wrote:
>> On 01/15/2015 02:19 PM, Michael Ellerman wrote:
>> If this was on a powerkvm guest set-indicator should be present for
>> hotplug (DLPAR) support. However, the surveillance indicator would not
>> be implemented. I know sometimes I forget if I'm on a powervm or
>> powerkvm guest. Just a thought.
> 
> Right that does explain it. I went looking for the KVM kernel/qemu code that
> implements set-indicator but couldn't find it. Presumably it's in some branch
> other than the one I was looking at, or I was grepping for the wrong thing.
> 
> So I guess a printf there is probably not helpful, because it will fire always
> on PowerKVM (at least at the moment).

FWIW, the PAPR mentions that the surveillance indicator may not be
implemented. In that case -3 is returned.? I double checked that on my LPAR.

One option would be to warn only if the returned value is different from
0 and -3.

Cheers

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon
Date: Fri, 16 Jan 2015 11:19:53 +0100	[thread overview]
Message-ID: <54B8E5C9.5090006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1421377361.18166.2.camel@ellerman.id.au>

On 16/01/2015 04:02, Michael Ellerman wrote:
> On Thu, 2015-01-15 at 15:41 -0800, Tyrel Datwyler wrote:
>> On 01/15/2015 02:19 PM, Michael Ellerman wrote:
>> If this was on a powerkvm guest set-indicator should be present for
>> hotplug (DLPAR) support. However, the surveillance indicator would not
>> be implemented. I know sometimes I forget if I'm on a powervm or
>> powerkvm guest. Just a thought.
> 
> Right that does explain it. I went looking for the KVM kernel/qemu code that
> implements set-indicator but couldn't find it. Presumably it's in some branch
> other than the one I was looking at, or I was grepping for the wrong thing.
> 
> So I guess a printf there is probably not helpful, because it will fire always
> on PowerKVM (at least at the moment).

FWIW, the PAPR mentions that the surveillance indicator may not be
implemented. In that case -3 is returned.? I double checked that on my LPAR.

One option would be to warn only if the returned value is different from
0 and -3.

Cheers


  reply	other threads:[~2015-01-16 10:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 14:07 [PATCH] pseries/le: Fix endiannes issue in RTAS call from xmon Laurent Dufour
2014-11-24 14:07 ` Laurent Dufour
2014-11-26  3:31 ` Michael Ellerman
2014-11-26  8:19   ` Laurent Dufour
2015-01-15  4:25 ` [PATCH] " Michael Ellerman
2015-01-15  4:25   ` Michael Ellerman
2015-01-15 14:17   ` Laurent Dufour
2015-01-15 14:17     ` Laurent Dufour
2015-01-15 17:23   ` [PATCH] pseries/le: Fix another " Laurent Dufour
2015-01-15 17:23     ` Laurent Dufour
2015-01-15 19:44     ` Tyrel Datwyler
2015-01-15 19:44       ` Tyrel Datwyler
2015-01-15 22:19       ` Michael Ellerman
2015-01-15 22:19         ` Michael Ellerman
2015-01-15 23:41         ` Tyrel Datwyler
2015-01-15 23:41           ` Tyrel Datwyler
2015-01-16  3:02           ` Michael Ellerman
2015-01-16  3:02             ` Michael Ellerman
2015-01-16 10:19             ` Laurent Dufour [this message]
2015-01-16 10:19               ` Laurent Dufour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B8E5C9.5090006@linux.vnet.ibm.com \
    --to=ldufour@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=tyreld@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.