All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrew Lunn <andrew@lunn.ch>,
	cooloney@gmail.com, rpurdie@rpsys.net, "R,
	Vignesh" <vigneshr@ti.com>
Cc: devicetree@vger.kernel.org, Matthew.Fatheree@belkin.com,
	Sekhar Nori <nsekhar@ti.com>,
	linux-leds@vger.kernel.org, kaloz@openwrt.org,
	linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver
Date: Fri, 16 Jan 2015 16:52:12 +0200	[thread overview]
Message-ID: <54B9259C.3070403@ti.com> (raw)
In-Reply-To: <1421277308-3477-1-git-send-email-andrew@lunn.ch>


[-- Attachment #1.1: Type: text/plain, Size: 890 bytes --]

Hi,

On 15/01/15 01:15, Andrew Lunn wrote:
> This patchset is a driver for the TI tlc59116 16 Channel i2c LED
> driver. This driver is used on the Belkin WRT1900AC access point and
> the C code is derived from code Belkin contributed to OpenWRT.
> However it has been extensively re-written, and a device tree binding
> added to replace platform data.

We have a TLC59108 on one of our boards, and with a quick glance it
looks about the same as TLC59116, except the amount of outputs. Vignesh
wrote a driver for it and was about to send it for review.

However, Vignesh implemented it as a PWM driver. We use it for LCD
backlight (via pwm-backlight).

I'm not very familiar with LED and PWM drivers, but doesn't implementing
this as a LED driver prevent us from using it as a backlight? Whereas it
looks like PWM can be used as a led via pwm-leds (I think).

 Tomi



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver
Date: Fri, 16 Jan 2015 16:52:12 +0200	[thread overview]
Message-ID: <54B9259C.3070403@ti.com> (raw)
In-Reply-To: <1421277308-3477-1-git-send-email-andrew@lunn.ch>

Hi,

On 15/01/15 01:15, Andrew Lunn wrote:
> This patchset is a driver for the TI tlc59116 16 Channel i2c LED
> driver. This driver is used on the Belkin WRT1900AC access point and
> the C code is derived from code Belkin contributed to OpenWRT.
> However it has been extensively re-written, and a device tree binding
> added to replace platform data.

We have a TLC59108 on one of our boards, and with a quick glance it
looks about the same as TLC59116, except the amount of outputs. Vignesh
wrote a driver for it and was about to send it for review.

However, Vignesh implemented it as a PWM driver. We use it for LCD
backlight (via pwm-backlight).

I'm not very familiar with LED and PWM drivers, but doesn't implementing
this as a LED driver prevent us from using it as a backlight? Whereas it
looks like PWM can be used as a led via pwm-leds (I think).

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150116/dcd6c719/attachment.sig>

  parent reply	other threads:[~2015-01-16 14:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 23:15 [PATCHv3 0/2] Driver for TI tlc59116 16 Channel i2c LED driver Andrew Lunn
2015-01-14 23:15 ` Andrew Lunn
2015-01-14 23:15 ` [PATCHv3 1/2] leds: tlc59116: Document binding for the TI " Andrew Lunn
2015-01-14 23:15   ` Andrew Lunn
2015-01-14 23:15 ` [PATCHv3 2/2] leds: tlc59116: Driver " Andrew Lunn
2015-01-14 23:15   ` Andrew Lunn
2015-01-16 14:52 ` Tomi Valkeinen [this message]
2015-01-16 14:52   ` [PATCHv3 0/2] Driver for TI tlc59116 " Tomi Valkeinen
     [not found]   ` <54B9259C.3070403-l0cyMroinI0@public.gmane.org>
2015-01-16 15:55     ` Andrew Lunn
2015-01-16 15:55       ` Andrew Lunn
2015-01-16 17:50       ` R, Vignesh
2015-01-16 17:50         ` R, Vignesh
2015-01-16 19:10         ` Andrew Lunn
2015-01-16 19:10           ` Andrew Lunn
2015-01-16 19:17   ` Andrew Lunn
2015-01-16 19:17     ` Andrew Lunn
2015-01-20  9:53     ` Tomi Valkeinen
2015-01-20  9:53       ` Tomi Valkeinen
2015-01-20 13:26       ` Andrew Lunn
2015-01-20 13:26         ` Andrew Lunn
     [not found]         ` <20150120132613.GJ2938-g2DYL2Zd6BY@public.gmane.org>
2015-01-20 13:32           ` Tomi Valkeinen
2015-01-20 13:32             ` Tomi Valkeinen
2015-01-20 13:40             ` Andrew Lunn
2015-01-20 13:40               ` Andrew Lunn
2015-01-20 13:33         ` Geert Uytterhoeven
2015-01-20 13:33           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B9259C.3070403@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=Matthew.Fatheree@belkin.com \
    --cc=andrew@lunn.ch \
    --cc=cooloney@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kaloz@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rpurdie@rpsys.net \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.