From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Simon Kelley <simon@thekelleys.org.uk>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp
Date: Fri, 16 Jan 2015 21:17:09 +0300 [thread overview]
Message-ID: <54B955A5.3090901@cogentembedded.com> (raw)
In-Reply-To: <1421414907-26764-1-git-send-email-linux@rasmusvillemoes.dk>
Hello.
On 01/16/2015 04:28 PM, Rasmus Villemoes wrote:
> The kernel's string library does in fact have strcasecmp, at least
> since ded220bd8f08. Moreover, this open-coded version is in fact
Please also specify that commit's summary line in parens.
> wrong: If the strings only differ in their last character, a and b
> have already been incremented to point to the terminating nul bytes,
NUL.
> so they would be treated as equal.
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Rasmus Villemoes
<linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>,
Simon Kelley
<simon-xn1N/tgparsycpQjotevgVpr/1R2p/CL@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp
Date: Fri, 16 Jan 2015 21:17:09 +0300 [thread overview]
Message-ID: <54B955A5.3090901@cogentembedded.com> (raw)
In-Reply-To: <1421414907-26764-1-git-send-email-linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
Hello.
On 01/16/2015 04:28 PM, Rasmus Villemoes wrote:
> The kernel's string library does in fact have strcasecmp, at least
> since ded220bd8f08. Moreover, this open-coded version is in fact
Please also specify that commit's summary line in parens.
> wrong: If the strings only differ in their last character, a and b
> have already been incremented to point to the terminating nul bytes,
NUL.
> so they would be treated as equal.
> Signed-off-by: Rasmus Villemoes <linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-16 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 13:28 [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp Rasmus Villemoes
2015-01-16 18:17 ` Sergei Shtylyov [this message]
2015-01-16 18:17 ` Sergei Shtylyov
2015-01-21 11:52 ` [PATCH v2] " Rasmus Villemoes
2015-01-23 19:40 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B955A5.3090901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.